835210 - FOTA updates don't seem to be working anymore.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Dave Hylands [:dhylands]]

Applying a FOTA update doesn't seem to work any more.

Comment 1

[Dave Hylands [:dhylands]]

Attachment: WIP: Locates fota destination in /data/local/updates/fota or /sdcard/updates/fota

With these changes, the update is downloaded and applied.

I've been testing with the emulator, which doesn't have librecovery.so so it fails to reboot into recovery. I'll test on a real device tomorrow.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

This WIP works on my unagi, I can now enter FOTA update procedure after downloading the MAR file.

Comment 3

[Dave Hylands [:dhylands]]

Attachment: Locates fota destination is /data/local/updates/fota or /mnt/sdcard/updates/fota - v2

I also threw in some better error handling if librecovery.so doesn't exist (which is what happens on the emulator).

Asking fabrice to review since Marshall is still PTO until next week.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 707380 [details] [diff] [review]
Locates fota destination is /data/local/updates/fota or /mnt/sdcard/updates/fota - v2

Review of attachment 707380 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/DirectoryProvider.js
@@ +75,1 @@
>        return file;

I think we want to set persistent.value = true on these. They are unlikely to change during runtime...

Comment 6

[Dave Hylands [:dhylands]]

persistent is currently being set to false, since the returned directory toggles between /data/local and /mnt/sdcard based on free space and/or availability (the user can pull the sdcard).

https://hg.mozilla.org/integration/mozilla-inbound/rev/3867507b9419

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3867507b9419

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/4e99ce0836e9
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/c54e43de18ff

Comment 9

[Jeni]

Verified fix on Unagi Build ID 20130219070200 Dec 5 Kernel.