835257 - [OPEN_][WIFI] Setting a custom AP which ssid name is over 32 characters also can be saved.(617001981003)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Firefox_Mozilla]

Steps to reproduce:
1.go into setting and turn on wifi;
2.go into manage network setting in wifi;
3.tap "join hidden network";
4.enter ssid network name and password and then save;

Expected results:
it can be saved successfully.
Actual results:
1. if the entering number of the ssid network name is over 32, it can not be saved successful and does not have any hint. 
notes: in settings-internet share-hotspot settings, we can modify the ssid network name over 32 characters. And when the ssid network name long, it is shown overlay.

Comment 1

[Firefox_Mozilla]

Attachment: interface overlay

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] raylin:835257-limit-join-network-ssid-length > mozilla-b2g:master

Comment 3

[Ray Lin[:ralin]]

Comment on attachment 8699308 [details] [review]
[gaia] raylin:835257-limit-join-network-ssid-length > mozilla-b2g:master

Hi,

I took a quick look at this bug, and found that:
1. overlay problem in hot spot setting is already fixed.
2. user actually can enter SSID name over 32 chars without any check or warning. The strange point is that we do implement check mechanism to prevent this happen (https://github.com/raylin/gaia/blob/f63fee32/apps/settings/js/panels/wifi_join_hidden/panel.js#L26), but could not be triggered normally.

Therefore, I changed the way of event binding and now we can stop user from entering more than 32 chars.

Thanks!!

Comment 4

[[e-mail]]

Comment on attachment 8699308 [details] [review]
[gaia] raylin:835257-limit-join-network-ssid-length > mozilla-b2g:master

Good catch! thanks.

Comment 5

[Ray Lin[:ralin]]

https://github.com/mozilla-b2g/gaia/commit/cdc43fd341a39104c8feac12ae6580ba11933b6f