Closed Bug 835285 Opened 13 years ago Closed 13 years ago

Attempting to sync empty Google calendar can result in JS error which causes sync failures.

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.0 fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- verified
b2g18-v1.0.0 --- fixed

People

(Reporter: maat, Unassigned)

Details

(Whiteboard: interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE)

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7830
355 bytes, text/html
kgrandon
: review+
Details
**DESCRIPTION** Newley added Google calendar not importing existing events upon synchronizing **PATH** 1) create events in Google calendar 2) open calendar app on phone that has no calendars synchronized to it 3) open try using icon in top left hand corner of screen 4) select the plus sign in top right hand corner of tray 5) select google from options displayed 6) enter google account information and select Save **EXPECTED** after synchronization any content in existing google calendar will have been imported into calendar app on phone **ACTUAL** no content in existing google calendar is imported into calendar app on phone after synchronization **Build Identifier** 20130127231539
[TEF_REQ] as Feature required for TEF build.
Whiteboard: interaction [UX-P1], [TEF_REQ]
Umm...that sounds bad. Can you reproduce this with a specific account? Or are you seeing this generally with multiple accounts? I need more info to take this forward.
Flags: needinfo?(aymanmaat)
I can also reproduce it with at least 2 google accounts on unagi with last update.
Flags: needinfo?(aymanmaat)
Well that sucks. I'll go check as well. What regressed here? James?
blocking-b2g: --- → tef?
Flags: needinfo?(jlal)
I dont know if it is useful or not, but my agendas are remote agendas (they are imported in google agenda from a remote address).
OK, I investigated this and can reproduce a similar situation... When we request events from a secondary calendar that has no events we encounter a JavaScript error because we expect calendar data as part of the request. Having no events could mean we simply don't have access to a specific calendar. This should be tef+ the fix is simple and should help us across other CalDAV implementations... I previously could not reproduce this so I am not sure when these changes happened.
Flags: needinfo?(jlal)
Keywords: regression, regressionwindow-wanted
Summary: [CALENDAR] Newley added Google calendar not importing existing events upon synchronizing → Attempting to sync empty Google calendar can result in JS error which causes sync failures.
Comment on attachment 707187 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7830 CalDAV lib only fix... the review was done there...
Attachment #707187 - Flags: review+
blocking-b2g: tef? → tef+
Comment on attachment 707187 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7830 gaia only approach to fix (this is much better)
Attachment #707187 - Flags: review+ → review?(kgrandon)
Comment on attachment 707187 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7830 ><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/7830"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/7830">https://github.com/mozilla-b2g/gaia/pull/7830</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #707187 - Attachment description: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7827 → Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7830
Attachment #707187 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Keywords: verifyme
Whiteboard: interaction [UX-P1], [TEF_REQ] → interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE
John - can you confirm this was uplifted to both v1-train and v1.0.0 branches?
status-b2g18-v1.0.0: --- → affected
v1-train: c37feba266474f10d9c9ec6c38c0641b3f7e6c47 v1.0.0: d84f99118a07a5edc4c6e408fd1ef29470e4bb12
status-b2g18-v1.0.0: affected → fixed
Verified on 1/30 with importing multiple google calendars in which the 2nd calendar has no events.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: