835318 - Error adding skills with non-latin chars.

Status: RESOLVED WONTFIX

(Participation Infrastructure :: Phonebook, defect)

Comment 1

[Matt Brandt [:mbrandt]]

Can you add minimal steps to reproduce? This will help QA verify once the patch lands.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

To reproduce:

- Go to 'edit my profile'
- Under 'skills' tab
- Type a few skills with non-ascii chars like 'φωτογραφία'
- Skills get removed from the list :/

Comment 3

[Matt Brandt [:mbrandt]]

Has this landed on stage on prod? - the /user/edit#skills form prevents using non-ascii characters in the groups, skills, and language sections.

example:
- tuna␀run
- φωτογραφία

Comment 4

[Giorgos Logiotatidis [:giorgos]]

No love for this bug yet, the 'new' flag is up to date.

Comment 5

[Vuyisile Ndlovu [:terrameijar]]

same is true in staging. Experienced the same when running my tests.

Comment 7

[Dan Poirier [:dpoirier]]

Fix is likely similar to that for 740990, but replace A-Za-z0-9 in the regexes with \w and add the unicode flag.

Comment 8

[xds_xps_ivx]

It happens even with latin characters. Any accentuation is affected, like:
á, é, í, ó, ú, ü <- those are fairly common in spanish

Comment 9

[Nikos Roussos [:comzeradd]]

After program meeting non-latin skills shouldn't be allowed. Closing this in favor of #1155623.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Can we remove the test, which is currently marked as expected to fail? https://github.com/mozilla/mozillians-tests/blob/4de508025772b7a95d3969db292ca9ddea5dc5a1/tests/test_profile.py#L171-L198

Comment 11

[Tasos Katsoulas [:tasos]]

Per comment 9, I think we can safely remove it.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Tasos Katsoulas [:tasos] from comment #11)
> Per comment 9, I think we can safely remove it.

Thanks. It was removed in https://github.com/mozilla/mozillians-tests/commit/07015bbaf4ee5c0bef2bcffe9fd762aad6c70db2