835345 - Preloaded contacts for carriers during build time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[David Palomino [:dpalomino]]

Hi, 

One of the key customization requests from carriers is the ability of prepopulating the Address Book with some carrier-specific contacts (most of them related to Customer Care). 

Depending on the SIM card (on country MCC code) those contacts could be inserted in the FTE (for instance). 

Thanks, 
David

Comment 1

[David Palomino [:dpalomino]]

Hi again, 

This issue is critical for getting a single variant version (mandatory requirement for latam countries). Nominating for tef+. 

Thanks, 
David

Comment 2

[Andrew Overholt [:overholt]]

The tef? triagers discussed this today.  While it is obviously important, it seems like a late feature request that puts v1 at risk.

One option Lucas suggested was doing it during the build.  That's not as nice as doing it during the FTE but it might be easier.

It would be great to get product input here.

Comment 3

[Daniel Coloma:dcoloma]

(In reply to Andrew Overholt [:overholt] from comment #2)
> The tef? triagers discussed this today.  While it is obviously important, it
> seems like a late feature request that puts v1 at risk.
> 
> One option Lucas suggested was doing it during the build.  That's not as
> nice as doing it during the FTE but it might be easier.
> 
> It would be great to get product input here.

I agree with the option of doing it during the build. Indeed, we have already a patch that does it and this what we agreed with the product team. The question is whether this should be part of the default Gaia build chain (my opinion is that we should do it as the risk is close to nil) or we could share it with the OEMs (I don't like this option as it introduces fragmentation).

Comment 4

[Lucas Adamski [:ladamski]]

We can do the build-time option to pre-populate the contacts, but I don't think we should do the FTE option for 1.0.0.  As such I'm going to minus this specific bug, unless you want to morph it into the build-time bug.

Comment 5

[Daniel Coloma:dcoloma]

(In reply to Lucas Adamski from comment #4)
> We can do the build-time option to pre-populate the contacts, but I don't
> think we should do the FTE option for 1.0.0.  As such I'm going to minus
> this specific bug, unless you want to morph it into the build-time bug.

I agree with your proposal (as I did in comment 3), but... in which triage has this discussion  taken place? I could have mentioned it there and clarify, but I have not seen nothing in the schedule for this time today

Comment 6

[Daniel Coloma:dcoloma]

Changed the name to reflect the idea, during build time, it should be possible to add some contacts to the device. 

Albert has already a working patch for this one. Nominating this again given the importance for the launch and the low risk it has (it does not affect the device code but the build system).

Comment 7

[David Palomino [:dpalomino]]

As commented in previous Dani's comment, nominating this again.

Comment 8

[Albert [:albert]]

Attachment: Default contacts JSON file

Comment 9

[Albert [:albert]]

Attachment: Added support to preloaded contacts at build time

Comment 10

[David Palomino [:dpalomino]]

Hi again, 

As this is a certification requirement for several carriers, adding the dep to cert meta bug. 

Br, 
David

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 709670 [details]
Added support to preloaded contacts at build time

Nothing major but I would like to see a new version of the patch.

Comment 12

[Albert [:albert]]

Comment on attachment 709670 [details]
Added support to preloaded contacts at build time

Modified

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 709670 [details]
Added support to preloaded contacts at build time

Sounds good but let's removed the unwanted 'console' change

Comment 14

[Albert [:albert]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #13)
> Comment on attachment 709670 [details]
> Added support to preloaded contacts at build time
> 
> Sounds good but let's removed the unwanted 'console' change

Fixed, it was a confusion between different repos

Comment 15

[Albert [:albert]]

https://github.com/mozilla-b2g/gaia/commit/3f6f48dbe8b7437ea3f8f476a1168f251ae2aa93

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: fc0489147c2c353e653638a0bcc25b59cf3f0532
v1.0.0: 2c225d4a93e4e5dd85103955949cfcd8201e096f

Comment 17

[Peter Dolanjski [:pdol]]

Removing needinfo since decision to do build time contact preload was reached.

Comment 18

[amiller]

No Test case creation is needed in moztrap for this issue. Test case for this issue will be created by partners.

Comment 19

[amiller]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 20

[cbarker]

David Palomino if you can Verify this bug out, it would be much appreciated.

Comment 21

[David Palomino [:dpalomino]]

Hi, 

Sorry for the delay. 

This has been included by the vendor in the build specific for customization testing, now it's been retested by testhouse responsible from the certification. 

When retested I'll let you know. 

Thanks!
David

Comment 22

[isabelrios]

Contacts preloaded now appear in the addressbook.
Build id: 20130421003941
Gaia:f2a9d81

Comment 23

[Shally Li（leave from Mozilla）]

Per comment 22,I clear "Verifyme".