Closed
Bug 835503
Opened 9 years ago
Closed 9 years ago
Remove nsCycleCollector::ShouldBeFreed/WasFreed
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: peterv, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
8.55 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
|
9.42 KB,
patch
|
Details | Diff | Splinter Review |
They add and remove to/from mExpectedGarbage, but nothing ever uses mExpectedGarbage anymore.
|
||
Comment 2•9 years ago
|
||
I guess we have other infrastructure in place to detect windows we expect to be freed not being freed, in the test harness.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bugs
|
|
Assignee | |
Comment 3•9 years ago
|
||
Seems to compile on debug build.
Attachment #707299 -
Flags: review?(continuation)
|
|
||
Updated•9 years ago
|
Attachment #707299 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
I thought I had removed the methods from nsCycleCollector.h too, but maybe not or the change got lost.
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9f22692e4404
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•