Remove nsCycleCollector::ShouldBeFreed/WasFreed

RESOLVED FIXED in mozilla21

Status

()

Product:
Core
Component:
XPCOM
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: peterv, Assigned: smaug)

Tracking

(Blocks: 1 bug)

Version:
Trunk
Target:
mozilla21
Points:
---
Duplicates:
835505

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

patch
8.55 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
remove from .h too
9.42 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

•
5 years ago 
They add and remove to/from mExpectedGarbage, but nothing ever uses mExpectedGarbage anymore.
 (Assignee)

Updated

•
5 years ago
Duplicate of this bug: 835505

Comment 2

•
5 years ago 
I guess we have other infrastructure in place to detect windows we expect to be freed not being freed, in the test harness.
 (Assignee)

Updated

•
5 years ago
Assignee: nobody → bugs
 (Assignee)

Comment 3

•
5 years ago 
Created attachment 707299 [details] [diff] [review]
patch

Seems to compile on debug build.
Attachment #707299 - Flags: review?(continuation)
Attachment #707299 - Flags: review?(continuation) → review+
Blocks: 749370
 (Assignee)

Comment 4

•
5 years ago 
Created attachment 707505 [details] [diff] [review]
remove from .h too

I thought I had removed the methods from nsCycleCollector.h too, but maybe not
or the change got lost.
 (Assignee)

Comment 5

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/9f22692e4404
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
No longer depends on: 837131
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.