835555 - Progress when importing SIM contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Bartosz Piec]

There should be a progress bar (or even a text saying "1 of x") when importing contacts from SIM card. I had over 500 contacts and it took several minutes to import when I didn't know if that hadn't freeze.

Comment 1

[Jose Manuel Cantera]

A non difficult fix but a nice UX improvement aligning it with how FB import works. Not a tef+ blocker but IMHO a tracking-b2g+ one.

Comment 3

[Victoria Gerchinhoren [:vicky]]

Is not the same bug. This bug is about importing contacts, the one that you marked as duplicated is for the overlay that says "Please hold on, we're connecting to obtain your friend list. This may take a couple of minutes"

Comment 4

[Jose Manuel Cantera]

(In reply to Victoria Gerchinhoren from comment #3)
> Is not the same bug. This bug is about importing contacts, the one that you
> marked as duplicated is for the overlay that says "Please hold on, we're

That's a FB message, please check. 

> connecting to obtain your friend list. This may take a couple of minutes"

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

This is a UX feature/polish and not a blocker for v1.0 release.  Nominate a fix for approval when ready and we can evaluate the risk of uplifting to available branches.

Comment 6

[Jose Manuel Cantera]

Attachment: Pointer to GH 7868 PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: User cannot monitor the import status
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 708201 [details]
Pointer to GH 7868 PR

Approving this for uplift to v1.0.0 and v1-train branches once it's cleared the other reviews.  It's a low risk, UX-P1, and will help with some other bugs like bug 832868.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 708201 [details]
Pointer to GH 7868 PR

Just some minimal comments on the PR, basically formatting stuff, nothing regarding the proper work.

Great job!

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 708201 [details]
Pointer to GH 7868 PR

r=me for the l10n part

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/c7534891362d5821befec705d5adefab3e55559a

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

blocking-b2g- seems like it implies wontfix, please feel free to correct.

v1-train: e9224cf0202ea101658d1b75e0a8fe3eb5d2ef5c

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'd like to reopen this as I found out in this commit, "Import SIM Contact" won't work anymore.

It still works in the previous commit 444321102afcd000c833e586c98cfc34c996314a.

Comment 14

[Jose Manuel Cantera]

It is working for us both in master and in v1-train. Nonetheless, please do not reopen old bugs, if something is not working, please open a new bug and provide all the details, including versions, of what's happening.