If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

IonMonkey: let dead comparison constants die

RESOLVED FIXED in mozilla21

Status

()

Product:
Core
Component:
JavaScript Engine
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

Version:
unspecified
Target:
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
1.98 KB, patch
dvander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Created attachment 707313 [details] [diff] [review]
fix

This patch fixes a bug where a constant that flows into an MCompare gets useRegister'd which causes it to be emitted as a dead register mov, even though the constant gets embedded as an immediate in the cmp instruction.
Attachment #707313 - Flags: review?(dvander)
Attachment #707313 - Flags: review?(dvander) → review+
 (Assignee)

Comment 1

•
5 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/a16bd9c18600

Comment 2

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/a16bd9c18600
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.