Closed
Bug 835582
Opened 11 years ago
Closed 11 years ago
Fix missing punctuation mark in welcome screen
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)
VERIFIED
FIXED
blocking-b2g | tef+ |
People
(Reporter: striptm, Assigned: striptm)
Details
Attachments
(1 file, 2 obsolete files)
In Spanish, the punctuation mark at the beginning of the sentence is mandatory.
Assignee | ||
Comment 1•11 years ago
|
||
Git patch https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23
Comment 2•11 years ago
|
||
Would you please link your pull request in a dummy patch (= html redirect) so I can review and merge it? E.g. like this one: https://bugzilla.mozilla.org/attachment.cgi?id=706999&action=edit
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 708018 [details] Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833 ><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23"><title>Bugzilla Code Review</title><p>You can review this work at <a href="https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23">https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23</a>, or wait 5 seconds to be redirected there automatically.</p>
Assignee | ||
Updated•11 years ago
|
Attachment #708018 -
Attachment is patch: false
Attachment #708018 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 5•11 years ago
|
||
Is this alright?
Comment 6•11 years ago
|
||
Fer, please link to your PR, not your commit.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 708018 [details] Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833 ><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/7833"><title>Bugzilla Code Review</title><p>You can review this work at <a href="https://github.com/mozilla-b2g/gaia/pull/7833">https://github.com/mozilla-b2g/gaia/pull/7833</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #708018 -
Attachment description: Pointer to Github PR: https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23 → Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833
Assignee | ||
Comment 8•11 years ago
|
||
Guillermo, like this?
Comment 9•11 years ago
|
||
No, change the link to your commit to: https://github.com/mozilla-b2g/gaia/pull/7833
Assignee | ||
Comment 10•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #708018 -
Attachment is obsolete: true
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #708185 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #708187 -
Flags: review?(kaze)
Comment 12•11 years ago
|
||
Comment on attachment 708187 [details] Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833 Thanks!
Attachment #708187 -
Flags: review?(kaze) → review+
Comment 13•11 years ago
|
||
Merged in master: https://github.com/mozilla-b2g/gaia/commit/cb0a23213e3f5ee9e62174595cd0cd6b20d66b6f … and nominating for tef?: zero risk + fixes the very first l10n mistake users will see for one of the three target locales.
blocking-b2g: --- → tef?
Updated•11 years ago
|
blocking-b2g: tef? → tef+
Comment 14•11 years ago
|
||
Who is going to land this?
Assignee: nobody → striptm
status-b2g18-v1.0.0:
--- → affected
Updated•11 years ago
|
status-b2g18:
--- → affected
Comment 15•11 years ago
|
||
Mark as fixed as this has been merged into master, according to line 28 of https://etherpad.mozilla.org/ep/pad/view/ro.ETIQfKPkzesF6j0I7u9/rev.1129
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 16•11 years ago
|
||
v1-train: 27975a13d8ba9a9683b9cc954c64893bafba88a7 v1.0.0: ff878c4b0a14053a61a524594b6eae3f468b84f1
Comment 17•11 years ago
|
||
This issue has been fixed on Unagi ,Build ID: 20130220093954 Kernel Dec 5 Gecko http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/140d06fc3397 Gaia b8bd76b1110417ef43a39ae28a2eeffbce1eda11
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•