Fix missing punctuation mark in welcome screen

VERIFIED FIXED

Status

Firefox OS
Gaia
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Fernando García Gómez, stripTM, Assigned: Fernando García Gómez, stripTM)

Tracking

unspecified
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
In Spanish, the punctuation mark at the beginning of the sentence is mandatory.
(Assignee)

Comment 1

5 years ago
Git patch https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23
Would you please link your pull request in a dummy patch (= html redirect) so I can review and merge it?

E.g. like this one: https://bugzilla.mozilla.org/attachment.cgi?id=706999&action=edit
(Assignee)

Comment 3

5 years ago
Created attachment 708018 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833
(Assignee)

Comment 4

5 years ago
Comment on attachment 708018 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833

><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23"><title>Bugzilla Code Review</title><p>You can review this work at <a href="https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23">https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23</a>, or wait 5 seconds to be redirected there automatically.</p>
(Assignee)

Updated

5 years ago
Attachment #708018 - Attachment is patch: false
Attachment #708018 - Attachment mime type: text/plain → text/html
(Assignee)

Comment 5

5 years ago
Is this alright?
Fer, please link to your PR, not your commit.
(Assignee)

Comment 7

5 years ago
Comment on attachment 708018 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833

><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/7833"><title>Bugzilla Code Review</title><p>You can review this work at <a href="https://github.com/mozilla-b2g/gaia/pull/7833">https://github.com/mozilla-b2g/gaia/pull/7833</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #708018 - Attachment description: Pointer to Github PR: https://github.com/stripTM/gaia/commit/5672c3d993599a0016f4ee4bf90da0fcd80a9c23 → Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833
(Assignee)

Comment 8

5 years ago
Guillermo, like this?
No, change the link to your commit to: https://github.com/mozilla-b2g/gaia/pull/7833
(Assignee)

Comment 10

5 years ago
Created attachment 708185 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833
(Assignee)

Updated

5 years ago
Attachment #708018 - Attachment is obsolete: true
(Assignee)

Comment 11

5 years ago
Created attachment 708187 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833
(Assignee)

Updated

5 years ago
Attachment #708185 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #708187 - Flags: review?(kaze)
Comment on attachment 708187 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7833

Thanks!
Attachment #708187 - Flags: review?(kaze) → review+
Merged in master: https://github.com/mozilla-b2g/gaia/commit/cb0a23213e3f5ee9e62174595cd0cd6b20d66b6f

… and nominating for tef?: zero risk + fixes the very first l10n mistake users will see for one of the three target locales.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Who is going to land this?
Assignee: nobody → striptm
status-b2g18-v1.0.0: --- → affected
status-b2g18: --- → affected
Mark as fixed as this has been merged into master, according to line 28 of

https://etherpad.mozilla.org/ep/pad/view/ro.ETIQfKPkzesF6j0I7u9/rev.1129
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
v1-train: 27975a13d8ba9a9683b9cc954c64893bafba88a7
v1.0.0: ff878c4b0a14053a61a524594b6eae3f468b84f1
status-b2g18: affected → fixed
status-b2g18-v1.0.0: affected → fixed

Comment 17

5 years ago
This issue has been fixed on Unagi ,Build ID: 20130220093954
Kernel Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/140d06fc3397
Gaia   b8bd76b1110417ef43a39ae28a2eeffbce1eda11
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.