835692 - media/mtransport/standalone/transportlayerdtls.cpp:409:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Just noticed a few instances of this go by:
{
media/mtransport/standalone/transportlayerdtls.cpp:409:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
for this line of code:
>409   if (digest_len > kMaxDigestLength)
https://mxr.mozilla.org/mozilla-central/source/media/mtransport/transportlayerdtls.cpp#409

There, digest_len is a size_t, and kMaxDigestLength is declared as an int:
https://mxr.mozilla.org/mozilla-central/source/media/mtransport/transportlayerdtls.h#62

Luckily, literally every other usage of kMaxDigestLength is just as an array-size:
https://mxr.mozilla.org/mozilla-central/ident?i=kMaxDigestLength

so we can & should just change it to a size_t, and this warning will go away.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 707452 [details] [diff] [review]
fix

Review of attachment 707452 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf9886e0d356

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf9886e0d356