8357 - Security Icon in chrome is wrong

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[davidm]

In th e6/15 build the icon is showing that I have a secure connection to
mozilla.org. Lets change the default state to unsecure so that users don't get
wrong information.

Comment 1

[davidm]

To see the security button you have to hit the notication component text

Comment 2

[don]

Bill, is this a bug or a feature?  Do we want to do anything about this now, or
wait until M9 when we do the security chrome?  Your call ...

Comment 3

[don]

Hmmm, if you click on the security button it hides itself.  Cool!  I think ...

Comment 4

[Bill Law]

The code that turns the security button on and off was put in to test it, since
one can't test it by going to a secure page.  We've just left it in up till now.
It might be better to turn it off, at least in non-debug builds.  I'm not sure
how to do that since there's no "#ifdef NS_DEBUG" in JavaScript...

I'll see if I can come up with some solution and turn it off entirely if not
(requiring security chrome testers to tweak their navigator.js file if they want
to make it work).

Comment 5

[Bill Law]

I just checked in this fix.  It disables the click-to-show-security-icon
"feature."  It can be re-enabled (for use when we implement the real chrome) by
simply tweaking the initialization of the debugSecuriy var.

Index: navigator.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/src/navigator.js,v
retrieving revision 1.23
retrieving revision 1.24
diff -r1.23 -r1.24
22a23
>   var debugSecurity = false; // Set this true to enable Security chrome
testing.
697a699,703
>             // Set debugSecurity (at top of file) to turn this code on.
>             if ( !debugSecurity ) {
>                 return;
>             }
>
701,702d706
<                 // Temporary till onchange handlers work.
<                 onSecurity();
709,710d712
<                 // Temporary till onchange handlers work.
<                 onSecurity();

Comment 6

[rubydoo123]

I checked on build 1999061808 and it is disabled, I am marking this as verified
and am presuming that someone will remember to turn this back on.