835764 - [Contacts UX] [Activity Indicator] Wrong use of spinner when connecting to facebook to import friends

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Victoria Gerchinhoren [:vicky]]

It should be a progress or activity bar (depending if the amount of data being loaded is known or unknown) as it's specified here:
https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Progress_.26_Activity_Indicators

Building blocks for consolidating this are implemented and approval pending:
https://bugzilla.mozilla.org/show_bug.cgi?id=822671

Comment 1

[Jose Manuel Cantera]

this is not a bug .. we use the progress bar once the Friends to import are ready and known ...

Comment 2

[Victoria Gerchinhoren [:vicky]]

Attachment: SHows incorrect use of activity indicator as well as wrong overlay layout

Comment 3

[Jose Manuel Cantera]

Comment on attachment 707554 [details]
SHows incorrect use of activity indicator as well as wrong overlay layout

nothing incorrect is there it was validated by UX months ago

Comment 4

[Jose Manuel Cantera]

Clarified with Victoria and this has to do with the new version of progress BBs. Sorry for the noise and confusion

Comment 5

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 8034

asking for UX review. later asking crdlc for the code, once UX gives OK.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Jose M. please remove:
#progressMsg {
  font-size: 1.8rem;
  padding: 1.5rem 0 1rem 0;
}
in curtain.css
This is overwriting BB styles.
Once fixed, the rest looks good to me.

Comment 7

[Jose Manuel Cantera]

thanks Arnau, now it has been implemented together with the suggestions of showing 0/n instead of 'waiting' message.

Now asking for dev and L10N review.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 712166 [details]
Pointer to GH PR 8034

I don't think we need separate progress strings now that the action is removed. Just 
progressFB               = {{current}}/{{total}}
should be fine. Also, the title didn't change, so the reference to it should stay _('progressFB3' + from + 'Title');

Comment 9

[Jose Manuel Cantera]

you are totally right, Axel, changes implemented as requested,

thanks!

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 712166 [details]
Pointer to GH PR 8034

works fine

Comment 11

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/399cb80e93434830de009793f1c1d5c4d7a2272c

Comment 12

[Jose Manuel Cantera]

Comment on attachment 712166 [details]
Pointer to GH PR 8034

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Progress BB and concepts changed by UX
User impact if declined: UX consistency
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 5c392f6a11d996fb62556ae4ad37de62bb98d1ec

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1