835774 - [Building Blocks] [Filters] Left border should be removed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Sergi]

Attachment: Correct Filter :: Screenshot

There's a 1px left border that needs to be removed. It should look like the roght border of this same component.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 2

[Sam Joch [:samjoch]]

Comment on attachment 710926 [details]
patch for UX branch

I agree with the changes.
But the dialer app didn't use BB filters.css ? 
Can you make those changes in the BB too and use BB in dialer app ?

Comment 3

[Sergi]

(In reply to Sam Joch [:samjoch] from comment #2)
> Comment on attachment 710926 [details]
> patch for UX branch
> 
> I agree with the changes.
> But the dialer app didn't use BB filters.css ? 
> Can you make those changes in the BB too and use BB in dialer app ?

The dialer doesn't use any filters. You mean we should be using them?

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Sam is right, changes should be done in the BB (BTW: it's tabs.css).
Sergi, they mean the filters in Call log, not the tabs in communications.

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I updated the PR :) thanks Sam

Comment 6

[Sam Joch [:samjoch]]

landed in uxbranch: https://github.com/gordonbrander/gaia/commit/daabb96a5b376f409ef131250ef976b0b3d8d0f6

Comment 7

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oddly I don't think I see that in v1 train even though it doesn't have the patch.

Note : ran into bug 854424

Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Comment 9

[Stephany Wilkes]

Comment on attachment 710926 [details]
patch for UX branch

Is this ready to raise to approval? with user value and risk in the comments? Our goal is to wrap up all Yedo and VxD changes by April 5th.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yes, I think so.

Comment 11

[Stephany Wilkes]

Pavel, can you raise this to approval? - I tried but I don't have the necessary permissions. Sorry!

Comment 12

[Sam Joch [:samjoch]]

Comment on attachment 710926 [details]
patch for UX branch

Master commit hash is 352ef94

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Filter edge borders blank in BB
Testing completed: Yes #c8
Risk to taking this patch (and alternatives if risky): low risk cause, only border none added.
String or UUID changes made by this patch: -

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 710926 [details]
patch for UX branch

This comes from the UX branch process where QA has already checked that it works. a=me.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 15

[Eric Pang [:epang] UX]

(In reply to John Ford [:jhford] from comment #14)
> I was not able to uplift this bug to v1-train.  If this bug has dependencies
> which are not marked in this bug, please comment on this bug.  If this bug
> depends on patches that aren't approved for v1-train, we need to re-evaluate
> the approval.  Otherwise, if this is just a merge conflict, you might be
> able to resolve it with:
> 
>   git checkout v1-train
>   git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
>   <RESOLVE MERGE CONFLICTS>
>   git commit

Pavel or Sam, can you look into this? Thanks!

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

My patch is on master, see here:
https://github.com/mozilla-b2g/gaia/blob/master/shared/style_unstable/tabs.css#L179

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #16)
> My patch is on master, see here:
> https://github.com/mozilla-b2g/gaia/blob/master/shared/style_unstable/tabs.
> css#L179

The problem is that this patch doesn't apply to the v1-train branch, which is where it needs to land as well.

Comment 18

[Stephany Wilkes]

Hi John: What can we do about this "doesn't apply" issue to get it to land in v1-train? Thanks!

Comment 19

[Maria Angeles Oteo (:oteo)]

(In reply to Stephany Wilkes from comment #18)
> Hi John: What can we do about this "doesn't apply" issue to get it to land
> in v1-train? Thanks!

Hi Stephany, when the Release engineers have problems with the uplifing, because it can not be merged cleanly to v1-train or another branch (normally because it have dependencies with another bugs not specified or there are differences between that branch and the master branch in the part of the code where the patch applies) the developer who has fixed the bug in master (in this case Pavel or Sam) have to do the merging of the patch in v1-train (resolving the conflicts that John can not do because he doesn't know neither the patch nor the code as well as the developers).

Remenber that when they do the uplift, they have to include in a comment the hash commit for v1-train (as they do when resolve the bug in master) and change the status of the flag status-b2g18 from "affected" to "fixed"

Comment 20

[James Lal [:lightsofapollo]]

We can't do more here without conflicts resolved. Please supply a patch or uplift directly.

Comment 21

[Stephany Wilkes]

Pavel or Sam, are either of you available to grab this one and resolve? Thanks!

Comment 22

[Sam Joch [:samjoch]]

Sorry this was not the right hash, the right one was 352ef946693d267d997b709fcc03537710289ec9 (cf. https://github.com/mozilla-b2g/gaia/pull/8794).

Uplifted in v1-train as well: https://github.com/mozilla-b2g/gaia/commit/486b7fdfa1fcd4494da67b9d4c556cbd71613727