Closed Bug 835799 Opened 10 years ago Closed 10 years ago

Add a timestamp property to the observer sent when an application has been called by app.launch() in order to have a better measure

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18+ fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 + fixed
b2g18-v1.0.0 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Keywords: perf, Whiteboard: [FFOS_perf] QARegressExclude)

Attachments

(1 file)

Patch
1.73 KB, patch
fabrice
: review+
lsblakk
: approval-mozilla-b2g18+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
The patch does what the title says.
Attachment #707611 - Flags: review?(fabrice)
Assignee: nobody → 21
blocking-b2g: --- → tef?
Will consider uplift after an approval nomination, but this is a non-blocker.
blocking-b2g: tef? → -
tracking-b2g18: --- → +
Attachment #707611 - Flags: review?(fabrice) → review+
Comment on attachment 707611 [details] [diff] [review]
Patch

This patch is really non-risky: it does not change any logic nor does and just add a new property on an element.

If we don't take this patch the value reported on the performance infrastructure will not take into account some time spend in Gecko before launching an applicaton... So this patch will regress performance on the dashboard but that's to be more precise...
Attachment #707611 - Flags: approval-mozilla-b2g18?
Comment on attachment 707611 [details] [diff] [review]
Patch

Approving for 1.0.0 (mozilla-b2g18_v_1_0_0 branch tip) uplift.
Attachment #707611 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Keywords: perf
If you want assistance getting this landed, feel free to set the checkin-needed flag up top.
https://hg.mozilla.org/mozilla-central/rev/47c28fd47df9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Marking this tef+ so it can be uplifted to v1.0.1 branch as it appears to have missed the 1/25 merge from v1-train and so is not on v1.0.1 as was expected.
blocking-b2g: - → tef+
status-b2g18-v1.0.1: --- → affected
This landed on b2g18 before v1_0_1 was forked. Note the cset is identical to the b2g18 one in comment 7.
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/445db979f18d
status-b2g18-v1.0.1: affected → fixed
Whiteboard: [FFOS_perf] → [FFOS_perf] QARegressExclude
No Test case creation is needed in moztrap for this issue.
Flags: in-moztrap-
Cannot verify, need steps to blackbox test this issue.
You need to log in before you can comment on or make changes to this bug.