Closed
Bug 835799
Opened 10 years ago
Closed 10 years ago
Add a timestamp property to the observer sent when an application has been called by app.launch() in order to have a better measure
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18+ fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
(Keywords: perf, Whiteboard: [FFOS_perf] QARegressExclude)
Attachments
(1 file)
1.73 KB,
patch
|
fabrice
:
review+
lsblakk
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
The patch does what the title says.
Attachment #707611 -
Flags: review?(fabrice)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [FFOS_perf]
Updated•10 years ago
|
Assignee: nobody → 21
Updated•10 years ago
|
blocking-b2g: --- → tef?
Comment 1•10 years ago
|
||
Will consider uplift after an approval nomination, but this is a non-blocker.
blocking-b2g: tef? → -
tracking-b2g18:
--- → +
Updated•10 years ago
|
Attachment #707611 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 707611 [details] [diff] [review] Patch This patch is really non-risky: it does not change any logic nor does and just add a new property on an element. If we don't take this patch the value reported on the performance infrastructure will not take into account some time spend in Gecko before launching an applicaton... So this patch will regress performance on the dashboard but that's to be more precise...
Attachment #707611 -
Flags: approval-mozilla-b2g18?
Comment 3•10 years ago
|
||
Comment on attachment 707611 [details] [diff] [review] Patch Approving for 1.0.0 (mozilla-b2g18_v_1_0_0 branch tip) uplift.
Attachment #707611 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Comment 4•10 years ago
|
||
If you want assistance getting this landed, feel free to set the checkin-needed flag up top.
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47c28fd47df9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/445db979f18d https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/572ecadc310d
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → fixed
status-firefox19:
--- → wontfix
status-firefox20:
--- → wontfix
status-firefox21:
--- → fixed
Target Milestone: --- → B2G C4 (2jan on)
Comment 8•10 years ago
|
||
Marking this tef+ so it can be uplifted to v1.0.1 branch as it appears to have missed the 1/25 merge from v1-train and so is not on v1.0.1 as was expected.
blocking-b2g: - → tef+
status-b2g18-v1.0.1:
--- → affected
Comment 9•10 years ago
|
||
This landed on b2g18 before v1_0_1 was forked. Note the cset is identical to the b2g18 one in comment 7. https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/445db979f18d
Comment 10•10 years ago
|
||
No Test case creation is needed in moztrap for this issue.
Flags: in-moztrap-
Comment 11•10 years ago
|
||
Cannot verify, need steps to blackbox test this issue.
You need to log in
before you can comment on or make changes to this bug.
Description
•