Closed
Bug 835813
Opened 12 years ago
Closed 12 years ago
Implement code for the UR study to collect CPU and memory stats on the Flash plugin
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: gfritzsche)
Details
(Whiteboard: [CtPUR:+])
Attachments
(1 file, 2 obsolete files)
12.39 KB,
patch
|
Details | Diff | Splinter Review |
For the UR study, I want code which will measure the memory and CPU consumption of the Flash plugin. I'd really like it to collect this data once per second. This should be sent to the observer service like this:
topic: "flashplugin-perfstats"
data: JSON of the form "{timestamp: N, pluginCPU: N, sandboxCPU: N, privbytes: N}"
where the timestamp is the result of JS_Now, and "privbytes" is the private bytes of the sandbox process. I don't think we really need to measure the memory usage of plugin-container, but you can include that if you want to.
https://docs.google.com/spreadsheet/ccc?key=0Apbc4eh5_A9wdGkxWlc0YjF1U2VVTHg3VXZKNFBobkE
This is a Windows-only request ;-)
Assignee | ||
Comment 1•12 years ago
|
||
Off-main-thread implementation.
It wasn't any additional work to add the broker cpu usage, so this delivers:
{"timestamp": N, "brokerCPU": N, "sandboxCPU": N, "pluginCPU": N, "privbytes": N}
Attachment #708357 -
Flags: feedback?(benjamin)
Assignee | ||
Comment 2•12 years ago
|
||
Fixed perf stats cleanup for abnormal plugin module shutdowns.
Attachment #708357 -
Attachment is obsolete: true
Attachment #708357 -
Flags: feedback?(benjamin)
Attachment #708542 -
Flags: feedback?(benjamin)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 708542 [details] [diff] [review]
Generate Flash perfomance data notifications
This looks good, except that you're using memorycounters.WorkingSetSize. I believe the metric we want for private bytes is .PagefileUsage:
"The Commit Charge value in bytes for this process. Commit Charge is the total amount of memory that the memory manager has committed for a running process."
Attachment #708542 -
Flags: feedback?(benjamin) → feedback+
Assignee | ||
Comment 4•12 years ago
|
||
Oh, right, thanks for the catch. Fixed.
Attachment #708542 -
Attachment is obsolete: true
Reporter | ||
Updated•12 years ago
|
Whiteboard: [CtPUR:+]
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•