BaselineCompiler: Optimized stub for string getelem

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 707640 [details] [diff] [review]
v1
Attachment #707640 - Flags: review?(jdemooij)
Comment on attachment 707640 [details] [diff] [review]
v1

Review of attachment 707640 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

::: js/src/ion/BaselineIC.cpp
@@ +1625,5 @@
>          // But for now we just bail.
>          return true;
>      }
>  
> +    if (lhs.isString() && rhs.isInt32() && res.isString()) {

Nit && !stub->hasStub(ICStub::GetElem_String)

To avoid adding the same stub multiple times.
Attachment #707640 - Flags: review?(jdemooij) → review+
(Assignee)

Updated

5 years ago
Assignee: general → evilpies
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/29b8d4586e54
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 836373
You need to log in before you can comment on or make changes to this bug.