835850 - Better support for timezone with non-whole-hour offsets in jstests

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

Set timezone to Asia/Kabul or Asia/Kathmandu and then run jstests.py. You'll notice quite a few test failures. Most of the them happen because tests/ecma/shell.js doesn't handle timezone with non-whole-hour offsets.

Comment 1

[André Bargull [:anba]]

Attachment: Timezone adjustment should include minutes field

This changeset evolved as a by-product of the bug 830304 patch, not sure who wants to review it.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 707667 [details] [diff] [review]
Timezone adjustment should include minutes field

I think I own this stuff now.  :-\  Rookie error, touching this stuff.  ;-)

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 707667 [details] [diff] [review]
Timezone adjustment should include minutes field

Review of attachment 707667 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sensible, and thanks for looking into this!  Fixing this garbage has been on my long-term list of things to do for...well, a long time.  You need me to push this, probably?

Comment 4

[André Bargull [:anba]]

All tests now run in PST8PDT (bug 1089745), so marking this bug as Won't Fix.