Closed Bug 835868 Opened 8 years ago Closed 8 years ago

Move permission check from TCPSocketParent::Init to NeckoParent::AllocPTCPSocket

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jdm, Assigned: glennal.buford)

Details

(Whiteboard: [mentor=jdm][lang=c++][good first bug])

Attachments

(1 file)

The security checks related to TCP sockets are a bit distributed, thereby making them difficult to read. Let's consolidate them in NeckoParent::AllocPTCPSocket.
Hi, I'd like to start on this bug. This is my first time contributing. Any guidance of where to start?
The check at http://mxr.mozilla.org/mozilla-central/source/dom/network/src/TCPSocketParent.cpp#51 should be moved to part of the conditional at http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoParent.cpp#271. There are no tests, so it just needs to build. TCPSocketParent::Init won't need the aBrowser argument anymore, either.
Attached patch proposed patchSplinter Review
FireInternalError isn't available in NeckoParent, so I followed suit with what other errors in NeckoParent does.
Attachment #709489 - Flags: review?(josh)
Comment on attachment 709489 [details] [diff] [review]
proposed patch

Review of attachment 709489 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Glenna! In the future, can you follow the instructions at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in to give your patches a commit message to make landing them easier?
Attachment #709489 - Flags: review?(josh) → review+
Assignee: nobody → glennal.buford
Sure, no problem! I can edit that one if you like.
Hi, I am a newbie. Can anyone tell me how to start fixing the bug and where to look for it.
This bug is fixed. I just forgot to commit Glenna's work (sorry!).
https://hg.mozilla.org/mozilla-central/rev/8d8cb708ed97
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.