835868 - Move permission check from TCPSocketParent::Init to NeckoParent::AllocPTCPSocket

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Josh Matthews [:jdm]]

The security checks related to TCP sockets are a bit distributed, thereby making them difficult to read. Let's consolidate them in NeckoParent::AllocPTCPSocket.

Comment 1

[Glenna]

Hi, I'd like to start on this bug. This is my first time contributing. Any guidance of where to start?

Comment 2

[Josh Matthews [:jdm]]

The check at http://mxr.mozilla.org/mozilla-central/source/dom/network/src/TCPSocketParent.cpp#51 should be moved to part of the conditional at http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoParent.cpp#271. There are no tests, so it just needs to build. TCPSocketParent::Init won't need the aBrowser argument anymore, either.

Comment 3

[Glenna]

Attachment: proposed patch

FireInternalError isn't available in NeckoParent, so I followed suit with what other errors in NeckoParent does.

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 709489 [details] [diff] [review]
proposed patch

Review of attachment 709489 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Glenna! In the future, can you follow the instructions at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in to give your patches a commit message to make landing them easier?

Comment 5

[Glenna]

Sure, no problem! I can edit that one if you like.

Comment 6

[Amol Pol]

Hi, I am a newbie. Can anyone tell me how to start fixing the bug and where to look for it.

Comment 7

[Josh Matthews [:jdm]]

This bug is fixed. I just forgot to commit Glenna's work (sorry!).

Comment 8

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8cb708ed97

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d8cb708ed97