835877 - IonMonkey: always allow inlining when functions are small

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

Currently the inline depth is max. 3. For raytrace we hit this limit to inline "Flog.RayTracer.Color". Now it would be possible to just increase the inline depth, but that could have bad consequences for larger scripts.

Therefore I think it would be good to not use this inline depth for small functions. For small functions the overhead of inlining is really small and we can discard the call.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Always allow inlining when functions are small

This is the outstanding issue for bug 835178 to inline it. This will increase the score with the mentioned 7% in that bug

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 707686 [details] [diff] [review]
Always allow inlining when functions are small

Review of attachment 707686 [details] [diff] [review]:
-----------------------------------------------------------------

We need some kind of cutoff to not blow out the stack - but you could make a hard cutoff of like 10, or use JS_CHECK_RECURSION().

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84597bf0120d

I added smallFunctionMaxInlineDepth with default value 10 for now, but could get increased if we find other places where it would help. I do think 10 should be more than enough though.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84597bf0120d