835891 - [Calendar UX VD] Remove account overlay - layout changes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Phone screen capture. Shows wrong implementation

Implement correct BB to this overlay. Explanatory Text should be bigger. This is a very important message, needs to have proper legibility.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Pavel, can you have a look, title text should be 25px, body 19px, like all the other dialogs.

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey, Patryk
unfortunately, this one is [BB] and the current implementation of this [BB] is:
Title : font-size: 1.6rem;font-weight: normal;line-height: 1em;
Description text : font-size: 2.2rem;font-weight: lighter;line-height: 2.3rem;

Can I change these settings for the [BB] (will affect a lot of Apps)?

Comment 3

[Eric Pang [:epang] UX]

Attachment: Mock Up of Remove Account Alert

Pavel, I've created a mock up for this screen that is consistent with our other system screens.  The alert type is 22px, 'Remove Account' is 16px Medium.

thx!

Comment 4

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 719644 [details]
Mock Up of Remove Account Alert

This mockup alignment is wrong, both texts should line up. Please correct.

Comment 5

[Eric Pang [:epang] UX]

(In reply to Victoria Gerchinhoren from comment #4)
> Comment on attachment 719644 [details]
> Mock Up of Remove Account Alert
> 
> This mockup alignment is wrong, both texts should line up. Please correct.

Hi Victoria, Przemek and I updated the specs for system screens and Pavel has implemented correctly.  I have no problem aligning all text with a 15px left margin.

Przemek, is this okay with you?

Pavel, if this is okay with Przemek please update all system screens (Even the ones without the confirmation header).  When spinners are present you can align them with a 15px left margin also.  Sorry for the change, thanks!

Comment 6

[Eric Pang [:epang] UX]

LG request for font updates.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 8

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #5)
> (In reply to Victoria Gerchinhoren from comment #4)
> > Comment on attachment 719644 [details]
> > Mock Up of Remove Account Alert
> > 
> > This mockup alignment is wrong, both texts should line up. Please correct.
> 
> Hi Victoria, Przemek and I updated the specs for system screens and Pavel
> has implemented correctly.  I have no problem aligning all text with a 15px
> left margin.
> 
> Przemek, is this okay with you?
> 
> Pavel, if this is okay with Przemek please update all system screens (Even
> the ones without the confirmation header).  When spinners are present you
> can align them with a 15px left margin also.  Sorry for the change, thanks!

Pavel, just wanted to check if this something you can update in the building blocks?  Or do you need to do each system screen individually?

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I can update the [BB] bot some apps use their own versions of this "confirm" screen.

Comment 10

[Eric Pang [:epang] UX]

Hi Pavel, Przemek also agrees with the change.  So you can go ahead and update all system screens to have a 15px margin (all text, spinners and lines).  Let me know if you have any questions.  Thanks!

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 13

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #11)
> Created attachment 731447 [details]
> After patch

Thanks Pavel, the formatting looks good now.

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

The font-size was fixed in another bug ... this one is only for layout changes

Comment 15

[Sam Joch [:samjoch]]

Landed in master https://github.com/mozilla-b2g/gaia/commit/1a0a3c3f64449000dac11a13e2721b49eba1f00b

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified the fix based on the description.  Not sure if we want that small of a font...

Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"
Unagi

Comment 17

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #16)
> Verified the fix based on the description.  Not sure if we want that small
> of a font...
> 
> Master build : 2013-04-05-03-05-43
> name="mozilla-central" revision="55f9e3e3dae7"  
> name="integration/gaia-central" revision="2005e026bdae"
> "gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
> "gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"
> Unagi

From Pavel's comment in # 14 it looks like the font size is taken care of in another bug.

Comment 18

[Jose Manuel Cantera]

Comment on attachment 731448 [details]
patch for Gaia repo

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Visual Design - Non Conformity
User impact if declined: High
Testing completed: 
Risk to taking this patch (and alternatives if risky): No risk
String or UUID changes made by this patch:

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 1a0a3c3f64449000dac11a13e2721b49eba1f00b as:
v1-train: 02aec39d4095e20cf1e8ccbd876cef10382d2349