XPIDL does not set the file length in the header for XPT files. Currently no logic relies on this, so its absence causes no problems. Bug 33193 -> http://bugzilla.mozilla.org/show_bug.cgi?id=33193 will need this bug resolved in order for it to be addressed
I'm attaching a patch that just fixes the file length not being set, so that it can be applied separately.
Setting review keyword, need reviews for this patch
looks like your patch follows in the style of the files you're patching, some of which are already managing control-flow with |goto|, so it's probably appropriate to fit into that framework, as you did. Man, it's just wierd to be reviewing C. :-) sr=scc.
r=jband. This looks right to me. I trust that you've been building the entire tree and ensuring that all the xpt files end up with the correct filelength info.
Patch checked in
Ugh, almost. Wrong bug
Patch checked in.
Marking Verified -