XPIDL does not store the file length in the header in XPT files

VERIFIED FIXED in mozilla0.9.4

Status

()

Core
XPCOM
P3
minor
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: David Bradley, Assigned: David Bradley)

Tracking

Trunk
mozilla0.9.4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: patch)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
XPIDL does not set the file length in the header for XPT files. Currently no 
logic relies on this, so its absence causes no problems.

Bug 33193 -> http://bugzilla.mozilla.org/show_bug.cgi?id=33193 will need this 
bug resolved in order for it to be addressed
(Assignee)

Updated

17 years ago
Priority: -- → P3
Target Milestone: --- → Future
(Assignee)

Updated

17 years ago
Blocks: 33193
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

17 years ago
I'm attaching a patch that just fixes the file length not being set, so that it 
can be applied separately.
(Assignee)

Comment 2

17 years ago
Created attachment 38272 [details] [diff] [review]
Patch to fix file length not getting set
(Assignee)

Comment 3

17 years ago
Setting review keyword, need reviews for this patch
Keywords: review
(Assignee)

Updated

17 years ago
Whiteboard: review

Comment 4

17 years ago
looks like your patch follows in the style of the files you're patching, some of
which are already managing control-flow with |goto|, so it's probably
appropriate to fit into that framework, as you did.  Man, it's just wierd to be
reviewing C. :-)  sr=scc.
(Assignee)

Updated

17 years ago
Target Milestone: Future → mozilla0.9.4

Comment 5

17 years ago
r=jband.

This looks right to me. I trust that you've been building the entire tree 
and ensuring that all the xpt files end up with the correct filelength info.
(Assignee)

Comment 6

17 years ago
Patch checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Keywords: review
Resolution: --- → FIXED
Whiteboard: review
(Assignee)

Comment 7

17 years ago
Ugh, almost. Wrong bug
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: patch
(Assignee)

Comment 8

17 years ago
Patch checked in.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
Marking Verified -
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: xpidl → XPCOM
QA Contact: pschwartau → xpcom
You need to log in before you can comment on or make changes to this bug.