Closed Bug 835924 Opened 13 years ago Closed 13 years ago

Intermittent browser_social_errorPage.js | is on social error page

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 22

People

(Reporter: RyanVM, Assigned: markh)

Details

(Keywords: intermittent-failure, Whiteboard: [qa-])

Attachments

(1 file)

wait for the error page to appear
1.44 KB, patch
Felipe
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=19243649&tree=Mozilla-Inbound Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitest-browser-chrome on 2013-01-29 08:47:58 PST for push c669c3af96d4 slave: talos-r4-lion-059 TEST-START | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | runSocialTestWithProvider: [{name:"provider 1", origin:"https://example.com", sidebarURL:"https://example.com/browser/browser/base/content/test/social/social_sidebar.html", workerURL:"https://example.com/browser/browser/base/content/test/social/social_worker.js", iconURL:"https://example.com/browser/browser/base/content/test/moz.png"}] TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | runSocialTestWithProvider: provider added TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testSidebar starting TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "https://example.com/browser/browser/base/content/test/social/social_worker.js" line: 0}] TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is on social error page TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is still on social error page TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is now on social sidebar page TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testSidebar complete TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testFlyout starting TEST-KNOWN-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | Bug 833207 - should be no callback when error page loads. TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is on social error page TEST-KNOWN-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | Bug 833207 - should be no callback when error page loads. TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is on social error page TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testFlyout complete TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testChatWindow starting TEST-KNOWN-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | Bug 833207 - should be no callback when error page loads. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is on social error page Stack trace: JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js :: tests.testChatWindow/</< :: line 156 JS frame :: chrome://mochikit/content/browser-test.js :: test_executeSoon/<.run :: line 510 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testChatWindow complete TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | social URL https://example.com/browser/browser/base/content/test/social/social_sidebar.html should not be in global history TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | social URL https://example.com/browser/browser/base/content/test/social/social_worker.js should not be in global history TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | social URL https://example.com/browser/browser/base/content/test/moz.png should not be in global history INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | finished in 1342ms
I have a try run at https://tbpl.mozilla.org/?tree=Try&rev=90139042587d which reproduced the problem and demonstrates we are simply checking too quickly for the error page. ie, the check: ok(SocialChatBar.chatbar.selectedChat.iframe.contentDocument.location.href.indexOf("about:socialerror?")==0, "is on social error page"); may occasionally fail, but if we do a waitForCondition(), it matches very quickly afterwards. The try run had *both* the immediate check and a waitForCondition(). The log shows: 01:19:36 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | is on social error page (https://example.com/browser/browser/base/content/test/social/social_chat.html) 01:19:36 INFO - Stack trace: ... 01:19:37 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_errorPage.js | sub-test testChatWindow complete So *only* the immediate check failed - the waitForCondition() was satisfied ~1 second later (probably less - the timestamps have only 1 second resolution)
Assignee: nobody → mhammond
Attachment #725193 - Flags: review?(felipc)
Attachment #725193 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/86bf4afce68f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: