835967 - [B2G][Dialer] The SIM PIN prompt is not displayed when going into the Dialer, after canceled on the unlock screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Darren]

Repro Steps:
1. Load the Unagi build 20130125070201.
2. Go to the settings app.
3. Select SIM security and turn on the SIM PIN.
4. Restart the device.
5. When unlocking the device cancel the SIM PIN with the "X" button in the top left.
6. Open the Dialer app.

Actual Results:
The SIM PIN prompt does not display.

Expected Results:
When the SIM PIN prompt is canceled on the unlock screen the prompt will display again when entering the Dialer.

Notes:
Build ID: 20130125070201
Kernel: Dec 5
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94a2d6fcdfde
Gaia:   6369dbf33b622faf4b4d176fed30b77c5c319dfc

UCID: set-072
Test Case: #4528

Repro rate-
4/4 on one device

Comment 1

[Darren]

https://moztrap.mozilla.org/runtests/run/702/env/296/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-tag=329

Comment 2

[Darren]

The issue repro'ed on build:
Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Comment 5

[Chris Kreinbring [:CKreinbring]]

Still repros in Unagi version 20130225070200.  After entering a phone number, the user receives a "No network connection" error page.  (See attachment)

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Kernel Date: Dec 5
Test Suite: SIM Security
UCID: set-072
https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=50&sortfield=order&sortdirection=asc&filter-id=4528&filter-suite=157

Comment 6

[Chris Kreinbring [:CKreinbring]]

Attachment: Screen shown after dialling a phone number

Comment 7

[Nick Davidson]

in reference to comment 5

Test Case # 4528
UCID: set-072

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=4528

Comment 8

[John Hammink]

There seems to a be a general bug that SIM PIN doesn't appear where it is supposed to.  see also 846574, 846563.  We need to do some exploratory testing and clarification on the requirements so that we understand how this works.

Comment 9

[amiller]

UCID: set-072
As a user I want to be able to click on a "Reset Phone" button, so that I can reset the phone to the factory condition. Upon restart, the first-run experience should be run.

Comment 10

[Peter Dolanjski [:pdol]]

(In reply to amiller from comment #9)
> UCID: set-072
> As a user I want to be able to click on a "Reset Phone" button, so that I
> can reset the phone to the factory condition. Upon restart, the first-run
> experience should be run.

The reset phone functionality is not related to this bug.

Comment 11

[Peter Dolanjski [:pdol]]

UCID: set-207
As a user I want the phone to display "SIM Locked" dialog box when the user cancels out of the SIM PIN entry process  and accesses SIM capabilities such as Dialer/Messaging so that I know I must "Unlock the SIM to access the cellular data network".

From the original user story, if the user cancels the SIM PIN entry, they should be made aware that an unlock is required and given the opportunity to take action when using the dialer/messaging.  

Josh/Casey - I wasn't involved in the original decisions around this.  Was this reprompt to be specific to dialer/messaging?

The way it stands at the moment, if a user cancels the pin entry, there is no way for them to get back to it unless they lock/unlock the device.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

It turns out this bug was caused by a regression, and my patch for Bug 835972 fixes the behavior.

https://github.com/mozilla-b2g/gaia/commit/b126eeb39ed9bfa1e5662386f74611d5d6527b18

Comment 13

[Mila Davydova]

Unable to verify the fix made in bug 835972, due to bug 861215.

This issue reproduces on the Inari build ID: 20130417070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia: 2d048a9bdae54e4ec7d48326c2130591c8b869b6

Dialog prompting user to unlock SIM does not appear in the Dialer or Message area.

Link to a failed TC: https://moztrap.mozilla.org/runtests/run/1105/env/316/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=2935
UCID: set-207

Comment 14

[sarsenyev]

This bug no longer reproduce on Inari device.

Environmental  Variables:
Inari Build ID: 20130501070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: 09046df332cd217cf4fad55c48ce9ce3f14ee5a4