836036 - Add MOZ_ESR lines to the mozconfig whitelist for comm-esr17

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mark Banner (:standard8)]

As we're building TB esr17 and TB mainstream 17 off of the same repository, we're using two sets of mozconfigs.

The esr ones have additional lines:

# Enable ESR branding
export MOZ_ESR=1

As we need to have either esr or release mozconfigs compared against nightly, we need to whitelist this line.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: add to the whitelist; move mozconfig checks into a script

I moved the mozconfig logic into a library so I could write this script that lets us compare w/out going through the hassle of release sanity. I tested with and without my whitelist changes, and adding my change to it shuts up verify_mozconfigs.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: fix logging in mozconfig compare script

Comment 3

[John Hopkins (:jhopkins)]

Comment on attachment 708750 [details] [diff] [review]
fix logging in mozconfig compare script

Unfortunately this patch is bitrotted already due to the pep8 reformatting change.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: unbitrot

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 709055 [details] [diff] [review]
unbitrot

Worked for my staging tests, landed!