All users were logged out of Bugzilla on October 13th, 2018

Add MOZ_ESR lines to the mozconfig whitelist for comm-esr17

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: standard8, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

As we're building TB esr17 and TB mainstream 17 off of the same repository, we're using two sets of mozconfigs.

The esr ones have additional lines:

# Enable ESR branding
export MOZ_ESR=1

As we need to have either esr or release mozconfigs compared against nightly, we need to whitelist this line.
(Assignee)

Updated

6 years ago
Blocks: 815302
(Assignee)

Updated

6 years ago
Assignee: nobody → bhearsum
Created attachment 708741 [details] [diff] [review]
add to the whitelist; move mozconfig checks into a script

I moved the mozconfig logic into a library so I could write this script that lets us compare w/out going through the hassle of release sanity. I tested with and without my whitelist changes, and adding my change to it shuts up verify_mozconfigs.
Attachment #708741 - Flags: review?(jhopkins)
Created attachment 708750 [details] [diff] [review]
fix logging in mozconfig compare script
Attachment #708741 - Attachment is obsolete: true
Attachment #708741 - Flags: review?(jhopkins)
Attachment #708750 - Flags: review?(jhopkins)
Comment on attachment 708750 [details] [diff] [review]
fix logging in mozconfig compare script

Unfortunately this patch is bitrotted already due to the pep8 reformatting change.
Attachment #708750 - Flags: review?(jhopkins) → review-
Created attachment 709055 [details] [diff] [review]
unbitrot
Attachment #709055 - Flags: review?(jhopkins)
Attachment #709055 - Flags: review?(jhopkins) → review+
Comment on attachment 709055 [details] [diff] [review]
unbitrot

Worked for my staging tests, landed!
Attachment #709055 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.