Mentor: jmathies, tabraldes, netzen
Whiteboard: [good first bug][lang=c++]
Hi, I would like to patch this bug. Please assist me how to go forward as I'm new to this.
Initial steps would be to do a local build and test to see how much time this Quit call actually takes to see if we can reproduce. http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportWin.cpp#777 https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites
I've already build firefox on windows. How to see the time Quit call actually take? Can you assist me. Thanks!!
(In reply to Manu Jain from comment #3) > I've already build firefox on windows. How to see the time Quit call > actually take? Can you assist me. Thanks!! Just roll your own timing routine that thows up a dialog with the result or prints to a log / console. We have time classes in mozilla, or you can use direct calls to the Windows performance counter apis.
Hi all, I timed the nsNativeAppSupportWin::Quit() method using the Windows QueryPerformanceCounter interface. I am getting times between 60~80 microseconds. Is there anything to be done prior to closing the Firefox window?
(In reply to Benoit Girard (:BenWa) from comment #0) > Profile: > http://people.mozilla.com/~bgirard/cleopatra/ > ?report=8f93d9cc0487a57413dc3abeaec40353ce4103c3 I think we want to look at that lock in the Quit method, understand what's might be holding it. According to the profile we were caught up in that.
i would like to fix this bug
Hello.I am a new developer.Can I work on this bug?
Priority: -- → P4
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][tpi:+]
(In reply to Shashwat Mishra from comment #8) > Hello.I am a new developer.Can I work on this bug? Sure, see comment 2 for some suggested first steps.
Hi, I am also a new developer that would like to take a look at this bug. If anything comes up I'll make a comment here. Thanks
Hi, I am a new developer and would like to take a look and work on this bug.
You need to log in before you can comment on or make changes to this bug.