836051 - nsNativeAppSupportWin::Quit takes 10 seconds on shutdown

Status: RESOLVED INCOMPLETE

(Core :: Widget: Win32, defect, P4)

Description

[Benoit Girard (:BenWa)]

Profile:
http://people.mozilla.com/~bgirard/cleopatra/?report=8f93d9cc0487a57413dc3abeaec40353ce4103c3

Comment 1

[Manu Jain]

Hi, I would like to patch this bug. Please assist me how to go forward as I'm new to this.

Comment 2

[Jim Mathies [:jimm]]

Initial steps would be to do a local build and test to see how much time this Quit call actually takes to see if we can reproduce.

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportWin.cpp#777
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites

Comment 3

[Manu Jain]

I've already build firefox on windows. How to see the time Quit call actually take? Can you assist me. Thanks!!

Comment 4

[Jim Mathies [:jimm]]

(In reply to Manu Jain from comment #3)
> I've already build firefox on windows. How to see the time Quit call
> actually take? Can you assist me. Thanks!!

Just roll your own timing routine that thows up a dialog with the result or prints to a log / console. We have time classes in mozilla, or you can use direct calls to the Windows performance counter apis.

Comment 5

[Sagara Paranagama]

Hi all, I timed the nsNativeAppSupportWin::Quit() method using the Windows QueryPerformanceCounter interface. I am getting times between 60~80 microseconds. Is there anything to be done prior to closing the Firefox window?

Comment 6

[Jim Mathies [:jimm]]

(In reply to Benoit Girard (:BenWa) from comment #0)
> Profile:
> http://people.mozilla.com/~bgirard/cleopatra/
> ?report=8f93d9cc0487a57413dc3abeaec40353ce4103c3


I think we want to look at that lock in the Quit method, understand what's might be holding it.  According to the profile we were caught up in that.

Comment 7

[Justin]

i would like to fix this bug

Comment 8

[Shashwat Mishra]

Hello.I am a new developer.Can I work on this bug?

Comment 9

[Jim Mathies [:jimm]]

(In reply to Shashwat Mishra from comment #8)
> Hello.I am a new developer.Can I work on this bug?

Sure, see comment 2 for some suggested first steps.

Comment 10

[chargadesilva]

Hi,

I am also a new developer that would like to take a look at this bug. If anything comes up I'll make a comment here.

Thanks

Comment 11

[p.sonalipatro]

Hi,

I am a new developer and would like to take a look and work on this bug.

Comment 12

[Gowry Sugathan]

Hi,
I am very new to this. I would like to work on this bug as my first one.

Comment 13

[Vaishnavi Kaulagi]

Hello,
Can I try this one too as a new developer?

Comment 14

[Stephen A Pohl [:spohl]]

The profile from comment 0 is unfortunately no longer accessible.