nsNativeAppSupportWin::Quit takes 10 seconds on shutdown

NEW
Unassigned

Status

()

Core
Widget: Win32
P4
normal
5 years ago
7 months ago

People

(Reporter: BenWa, Unassigned, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=c++][tpi:+])

Updated

4 years ago
OS: Mac OS X → Windows 7

Updated

4 years ago
Mentor: jmathies, tabraldes, netzen
Whiteboard: [good first bug][lang=c++]

Comment 1

4 years ago
Hi, I would like to patch this bug. Please assist me how to go forward as I'm new to this.

Comment 2

4 years ago
Initial steps would be to do a local build and test to see how much time this Quit call actually takes to see if we can reproduce.

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportWin.cpp#777
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites

Comment 3

4 years ago
I've already build firefox on windows. How to see the time Quit call actually take? Can you assist me. Thanks!!

Comment 4

4 years ago
(In reply to Manu Jain from comment #3)
> I've already build firefox on windows. How to see the time Quit call
> actually take? Can you assist me. Thanks!!

Just roll your own timing routine that thows up a dialog with the result or prints to a log / console. We have time classes in mozilla, or you can use direct calls to the Windows performance counter apis.

Comment 5

4 years ago
Hi all, I timed the nsNativeAppSupportWin::Quit() method using the Windows QueryPerformanceCounter interface. I am getting times between 60~80 microseconds. Is there anything to be done prior to closing the Firefox window?

Updated

4 years ago
Flags: needinfo?(jmathies)

Comment 6

4 years ago
(In reply to Benoit Girard (:BenWa) from comment #0)
> Profile:
> http://people.mozilla.com/~bgirard/cleopatra/
> ?report=8f93d9cc0487a57413dc3abeaec40353ce4103c3


I think we want to look at that lock in the Quit method, understand what's might be holding it.  According to the profile we were caught up in that.
Flags: needinfo?(jmathies)

Comment 7

4 years ago
i would like to fix this bug

Comment 8

a year ago
Hello.I am a new developer.Can I work on this bug?

Updated

a year ago
Priority: -- → P4
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][tpi:+]

Updated

a year ago
Mentor: netzen, timabraldes
(In reply to Shashwat Mishra from comment #8)
> Hello.I am a new developer.Can I work on this bug?

Sure, see comment 2 for some suggested first steps.

Comment 10

a year ago
Hi,

I am also a new developer that would like to take a look at this bug. If anything comes up I'll make a comment here.

Thanks

Comment 11

8 months ago
Hi,

I am a new developer and would like to take a look and work on this bug.
You need to log in before you can comment on or make changes to this bug.