Last Comment Bug 836086 - Lazy load keys.js
: Lazy load keys.js
Status: RESOLVED FIXED
[MemShrink]
:
Product: Cloud Services
Classification: Client Software
Component: Firefox Sync: Backend (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla21
Assigned To: Gregory Szorc [:gps] (away until 2017-03-20)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-29 16:02 PST by Gregory Szorc [:gps] (away until 2017-03-20)
Modified: 2013-02-06 03:41 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Lazy load keys.js, v1 (1.31 KB, patch)
2013-01-29 16:02 PST, Gregory Szorc [:gps] (away until 2017-03-20)
rnewman: review+
Details | Diff | Splinter Review

Description User image Gregory Szorc [:gps] (away until 2017-03-20) 2013-01-29 16:02:13 PST
Created attachment 707867 [details] [diff] [review]
Lazy load keys.js, v1

Sync is currently loading keys.js on startup even though it isn't needed unless Sync is active. We should lazy load it.

With compartment overhead, the attached patch saves ~98k.
Comment 1 User image Richard Newman [:rnewman] 2013-01-29 16:06:48 PST
Comment on attachment 707867 [details] [diff] [review]
Lazy load keys.js, v1

Review of attachment 707867 [details] [diff] [review]:
-----------------------------------------------------------------

Hah, neat.
Comment 2 User image Gregory Szorc [:gps] (away until 2017-03-20) 2013-01-29 16:48:43 PST
https://hg.mozilla.org/services/services-central/rev/193ab8cee72a
Comment 3 User image Gregory Szorc [:gps] (away until 2017-03-20) 2013-01-30 16:14:59 PST
https://hg.mozilla.org/mozilla-central/rev/193ab8cee72a

Note You need to log in before you can comment on or make changes to this bug.