836138 - Fix navier-stokes double array correctness bugs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Bug 833898 broke navier-stokes on octane, tripping some checksums in place to verify that the JS engine is, well, behaving correctly.  This fixes those; there were two distinct bugs --- the JM setelem IC happily ignored the conversion bits, and property type sets were not being frozen correctly for assignments.

This fix also improves the navier-stokes score.  Bug 833898 introduced a regression of ~1000 points on this benchmark, this fixes that so the score is a 600 point improvement on the pre-833898 state.  (Though I'd expect the improvement to be even more off hand, as we generate much better code now for navier-stoke's critical loop, the innermost loop in lin_solve).

It'd be nice if we had jit-tests based off the octane stuff, in the same fashion as we do for sunspider and v8-v5.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 707918 [details] [diff] [review]
patch

Review of attachment 707918 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85ea275d77b9

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85ea275d77b9