Closed Bug 836138 Opened 7 years ago Closed 7 years ago

Fix navier-stokes double array correctness bugs

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: bhackett, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 833898 broke navier-stokes on octane, tripping some checksums in place to verify that the JS engine is, well, behaving correctly.  This fixes those; there were two distinct bugs --- the JM setelem IC happily ignored the conversion bits, and property type sets were not being frozen correctly for assignments.

This fix also improves the navier-stokes score.  Bug 833898 introduced a regression of ~1000 points on this benchmark, this fixes that so the score is a 600 point improvement on the pre-833898 state.  (Though I'd expect the improvement to be even more off hand, as we generate much better code now for navier-stoke's critical loop, the innermost loop in lin_solve).

It'd be nice if we had jit-tests based off the octane stuff, in the same fashion as we do for sunspider and v8-v5.
Attachment #707918 - Flags: review?(jdemooij)
Comment on attachment 707918 [details] [diff] [review]
patch

Review of attachment 707918 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #707918 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/85ea275d77b9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.