836185 - JSCustomObjectBuilder.cpp triggers build warning "tools\msvs10\vc\include\typeinfo(157) : warning C4275: non dll-interface class 'stdext::exception' used as base for dll-interface class 'std::bad_cast'"

Status: RESOLVED INACTIVE

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

When building in /tools/profiler on MSVC, we hit:
{
JSCustomObjectBuilder.cpp

c:\tools\msvs10\vc\include\typeinfo(157) : warning C4275: non dll-interface class 'stdext::exception' used as base for dll-interface class 'std::bad_cast'

        c:\tools\msvs10\vc\include\exception(218) : see declaration of 'stdext::exception'

        c:\tools\msvs10\vc\include\typeinfo(156) : see declaration of 'std::bad_cast'

c:\tools\msvs10\vc\include\typeinfo(178) : warning C4275: non dll-interface class 'stdext::exception' used as base for dll-interface class 'std::bad_typeid'

        c:\tools\msvs10\vc\include\exception(218) : see declaration of 'stdext::exception'

        c:\tools\msvs10\vc\include\typeinfo(177) : see declaration of 'std::bad_typeid'
}

Sample logs w/ this warning:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19266818&tree=Try  (opt)
https://tbpl.mozilla.org/php/getParsedLog.php?id=19267547&tree=Try  (debug)

This prevents this directory from being marked as FAIL_ON_WARNINGS.  Here's a Try run w/ that marking, which is red on windows because of this:
 https://tbpl.mozilla.org/?tree=Try&rev=76953353f4fd

Comment 1

[Daniel Holbert [:dholbert]]

(I don't really understand what the warning is trying to say about this source file, FWIW... maybe one of the templates in the file is instantiated with a type that MSVC doesn't like, but it's tripping over itself when trying to tell us?)

Comment 2

[(no longer active)]

Wait.  Did we not fix this in bug 556886?

Comment 3

[Masatoshi Kimura [:emk]]

Bug 556886 would have no effect because <typeinfo> and <exception> aren't wrapped.
https://mxr.mozilla.org/mozilla-central/source/config/stl-headers

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

Compiling mozilla-central tip from yesterday, I get a ton of these - I see 2520 occurrences of typeinfo in the output from my latest build. Does this need a Core:XPCOM bug to review if typeinfo can be added to the stl-headers list (as the file says)?

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

No complaints/follow-up since 2014, and I don't remember seeing these warnings.