836218 - Crash Reporter's locale different from the build's one

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Scoobidiver (away)]

Loading https://bugzilla.mozilla.org/attachment.cgi?id=706876 with a French build displays a crash reporter with a different locale.
Three days ago, it was in Akan, now it's in Romansh.

Comment 1

[(not currently active) Ted Mielczarek]

Possible fallout from bug 780561? (Related: bug 833848).

Comment 2

[Mike Hommey [:glandium]]

Interestingly, this only affects windows builds.

Comment 3

[Alice0775 White]

in ja nightly,

Good:
http://hg.mozilla.org/mozilla-central/rev/52c92a6c6e24
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130126 Firefox/21.0 ID:20130126030941
http://hg.mozilla.org/mozilla-central/rev/f18b12139151
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130127 Firefox/21.0 ID:20130127031042

Bad:
http://hg.mozilla.org/mozilla-central/rev/80fed51ae074
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130128 Firefox/21.0 ID:20130128030943
http://hg.mozilla.org/mozilla-central/rev/0c45e6378f1f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130129 Firefox/21.0 ID:20130129030851

Comment 4

[Scoobidiver (away)]

Based on comment 3, the regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f18b12139151&tochange=80fed51ae074

Comment 5

[Mike Hommey [:glandium]]

Attachment: Always copy files instead of skipping when destination is newer when doing l10n-repacks

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/5f21061637d5

Comment 7

[Mike Hommey [:glandium]]

It looks like this wasn't enough. :(

Comment 8

[Mike Hommey [:glandium]]

In fact, I'm not sure what I was looking at, but it does look like it worked. I'd like qa to double check, though. At least, the last two french and japanese windows nightlies look normal.

Comment 9

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0

Verified fixed with Firefox 21 beta 3 (Build ID: 20130416200523) french and japanese builds. When loading the url from comment 0, the crash report is in the correct language, respectively french/japanese.