nsIMediaDevices (MediaEngineAudioSource and MediaEngineVideoSource) leak after using gum with UI

RESOLVED FIXED in mozilla21

Status

()

Core
WebRTC: Audio/Video
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

({mlk})

17 Branch
mozilla21
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [getUserMedia][blocking-gum+][MemShrink][qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
When using mozGetUserMedia, if the UI is enabled we leak a copy of every media source device and an nsTArray (and perhaps some related objects).  We don't see it in the mochitests as they suppress the permission UI.

Caused by copying an allocated nsTArray<nsCOMPtr <...> >, which is then dropped on the floor.
(Assignee)

Comment 1

4 years ago
Created attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor
(Assignee)

Updated

4 years ago
Attachment #708131 - Flags: review?(bzbarsky)
Comment on attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor

r=me
Attachment #708131 - Flags: review?(bzbarsky) → review+

Updated

4 years ago
Whiteboard: [getUserMedia][blocking-gum+]

Updated

4 years ago
Keywords: mlk
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cabffed38ccc
Target Milestone: --- → mozilla21
Whiteboard: [getUserMedia][blocking-gum+] → [getUserMedia][blocking-gum+][MemShrink]
https://hg.mozilla.org/mozilla-central/rev/cabffed38ccc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Whiteboard: [getUserMedia][blocking-gum+][MemShrink] → [getUserMedia][blocking-gum+][MemShrink][qa-]

Updated

4 years ago
Depends on: 815002
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.