Closed Bug 836294 Opened 7 years ago Closed 7 years ago

nsIMediaDevices (MediaEngineAudioSource and MediaEngineVideoSource) leak after using gum with UI

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

17 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: memory-leak, Whiteboard: [getUserMedia][blocking-gum+][MemShrink][qa-])

Attachments

(1 file)

When using mozGetUserMedia, if the UI is enabled we leak a copy of every media source device and an nsTArray (and perhaps some related objects).  We don't see it in the mochitests as they suppress the permission UI.

Caused by copying an allocated nsTArray<nsCOMPtr <...> >, which is then dropped on the floor.
Attachment #708131 - Flags: review?(bzbarsky)
Comment on attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor

r=me
Attachment #708131 - Flags: review?(bzbarsky) → review+
Whiteboard: [getUserMedia][blocking-gum+]
Keywords: mlk
Whiteboard: [getUserMedia][blocking-gum+] → [getUserMedia][blocking-gum+][MemShrink]
https://hg.mozilla.org/mozilla-central/rev/cabffed38ccc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [getUserMedia][blocking-gum+][MemShrink] → [getUserMedia][blocking-gum+][MemShrink][qa-]
Depends on: 815002
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.