Last Comment Bug 836294 - nsIMediaDevices (MediaEngineAudioSource and MediaEngineVideoSource) leak after using gum with UI
: nsIMediaDevices (MediaEngineAudioSource and MediaEngineVideoSource) leak afte...
Status: RESOLVED FIXED
[getUserMedia][blocking-gum+][MemShri...
: mlk
Product: Core
Classification: Components
Component: WebRTC: Audio/Video (show other bugs)
: 17 Branch
: All All
P1 normal (vote)
: mozilla21
Assigned To: Randell Jesup [:jesup]
: Jason Smith [:jsmith]
: Maire Reavy [:mreavy] Please needinfo me
Mentors:
Depends on: 815002
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-30 07:44 PST by Randell Jesup [:jesup]
Modified: 2013-02-06 03:41 PST (History)
5 users (show)
jsmith: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Don't drop array of media devices on the floor (3.26 KB, patch)
2013-01-30 07:45 PST, Randell Jesup [:jesup]
bzbarsky: review+
Details | Diff | Splinter Review

Description User image Randell Jesup [:jesup] 2013-01-30 07:44:06 PST
When using mozGetUserMedia, if the UI is enabled we leak a copy of every media source device and an nsTArray (and perhaps some related objects).  We don't see it in the mochitests as they suppress the permission UI.

Caused by copying an allocated nsTArray<nsCOMPtr <...> >, which is then dropped on the floor.
Comment 1 User image Randell Jesup [:jesup] 2013-01-30 07:45:04 PST
Created attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor
Comment 2 User image Boris Zbarsky [:bz] (still a bit busy) 2013-01-30 07:49:16 PST
Comment on attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor

r=me
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2013-01-31 13:39:18 PST
https://hg.mozilla.org/mozilla-central/rev/cabffed38ccc

Note You need to log in before you can comment on or make changes to this bug.