Closed Bug 836312 Opened 7 years ago Closed 7 years ago

GC: Sweep IonCode incrementally

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

When IonCode things were added to the collector they were set to be swept non-incrementally at the start of the sweep phase.  This isn't necessary - we have to sweep them on the main thread, but we can sweep them incrementally.
Attached patch Proposed fixSplinter Review
Attachment #708140 - Flags: review?(wmccloskey)
Comment on attachment 708140 [details] [diff] [review]
Proposed fix

Review of attachment 708140 [details] [diff] [review]:
-----------------------------------------------------------------

Can you keep PHASE_SWEEP_IONCODE?
Attachment #708140 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/3808b7673bde
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
I backed this out on Aurora because of bug 837370:
https://hg.mozilla.org/releases/mozilla-aurora/rev/1fa13f7f2050
Target Milestone: mozilla21 → mozilla22
You need to log in before you can comment on or make changes to this bug.