Closed
Bug 836367
Opened 12 years ago
Closed 12 years ago
Remove 'unlock' from mozb2g
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
We have a better maintained copy of this functionality in gaiatest (https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/atoms/gaia_lock_screen.js#L9); we should remove the unmaintained copy from mozb2g.
|
Assignee | |
Comment 1•12 years ago
|
||
wlach found that b2gmixin's version of unlock() didn't work. It's slightly different than the version in gaia-ui-tests. We probably only need one version of this code, and I think that gaia-ui-tests is where it should be, so let's get rid of it here.
Are there any consumers other than Eideticker?
Attachment #708408 -
Flags: review?(mdas)
|
||
Updated•12 years ago
|
Attachment #708408 -
Flags: review?(mdas) → review+
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → jgriffin
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•