Remove 'unlock' from mozb2g

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We have a better maintained copy of this functionality in gaiatest (https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/atoms/gaia_lock_screen.js#L9); we should remove the unmaintained copy from mozb2g.
(Assignee)

Comment 1

5 years ago
Created attachment 708408 [details] [diff] [review]
Remove unlock() from mozb2g

wlach found that b2gmixin's version of unlock() didn't work.  It's slightly different than the version in gaia-ui-tests.  We probably only need one version of this code, and I think that gaia-ui-tests is where it should be, so let's get rid of it here.

Are there any consumers other than Eideticker?
Attachment #708408 - Flags: review?(mdas)
Attachment #708408 - Flags: review?(mdas) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → jgriffin
(Assignee)

Comment 2

5 years ago
https://github.com/mozilla/mozbase/commit/06d1926e81aaba1a601d05d3b95d9194e96fdac2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.