83638 - Address Book's throbber extends (should be made a box)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID:  Fresh CVS pull @2:23 am, Friday, June 1st, 2001 ;-)
OS: Occurs on all platforms.

The addressbook's throbber is not aligned correctly vertically, and Joe
mentioned the fix would be to make it a <box>.

This is ugly ;-(.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Index: addressbook.xul
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/resources/content/addressbook.xul,v

retrieving revision 1.116
diff -u -r1.116 addressbook.xul
--- addressbook.xul     2001/05/18 01:20:43     1.116
+++ addressbook.xul     2001/06/01 09:34:07
@@ -238,11 +238,10 @@
         <!--button id="button_stop" class="other28" align="top" label="&stopBut
ton.label;" tooltip="aTooltip" tooltiptext="&stopButton.tooltip;" disabled="true
" oncommand="AbStop()"/>
         <button id="button_search" class="other28" align="top" label="&searchBu
tton.label;" disabled="true" tooltip="aTooltip" tooltiptext="&searchButton.toolt
ip;" oncommand="AbSearch()"/-->
                        </box>
-
-      <button class="plain" id="navigator-throbber" oncommand='goClickThrobber(
"addressbook.throbber.url")' tooltip="aTooltip" tooltiptext="&throbber.tooltip;"
>
-        <observes element="broadcaster_throbber" attribute="busy"/>
-      </button>
-    </toolbar>
+      <hbox id="throbber-box" autostretch="never">
+          <button id="navigator-throbber" oncommand='goClickThrobber("addressbo
ok.throbber.url")' tooltip="aTooltip" tooltiptext="&throbber.tooltip;"/>
+      </hbox>
+      </toolbar>
   </toolbox>

   <!-- The main address book three pane -->

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot, but it still looks a bit messed, I'm sure Joe will know what's up.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Wow, by that same token, Mail/News' throbber has the same condition (throbber
isn't aligned inside of the two horizontal lines).

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Joe, can I get an sr= on this?  Andrew or Candice, can I get an r=?  Thanks.

Comment 5

[Joe Hewitt (gone)]

Your </toolbar> tag is indented one level too many..

Fix that, and take the sr=hewitt

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Index: addressbook.xul
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/resources/content/addressbook.xul,v

retrieving revision 1.116
diff -u -r1.116 addressbook.xul
--- addressbook.xul     2001/05/18 01:20:43     1.116
+++ addressbook.xul     2001/06/01 22:55:44
@@ -238,10 +238,9 @@
         <!--button id="button_stop" class="other28" align="top" label="&stopBut
ton.label;" tooltip="aTooltip" tooltiptext="&stopButton.tooltip;" disabled="true
" oncommand="AbStop()"/>
         <button id="button_search" class="other28" align="top" label="&searchBu
tton.label;" disabled="true" tooltip="aTooltip" tooltiptext="&searchButton.toolt
ip;" oncommand="AbSearch()"/-->
                        </box>
-
-      <button class="plain" id="navigator-throbber" oncommand='goClickThrobber(
"addressbook.throbber.url")' tooltip="aTooltip" tooltiptext="&throbber.tooltip;"
>
-        <observes element="broadcaster_throbber" attribute="busy"/>
-      </button>
+      <hbox id="throbber-box" autostretch="never">
+          <button id="navigator-throbber" oncommand='goClickThrobber("addressbo
ok.throbber.url")' tooltip="aTooltip" tooltiptext="&throbber.tooltip;"/>
+      </hbox>
     </toolbar>
   </toolbox>

Comment 7

[Todd Pringle]

themes triage:  moving to 0.9.3, priority P3

Comment 8

[Stephen Walker]

*** Bug 85506 has been marked as a duplicate of this bug. ***

Comment 9

[Håkan Waara]

yeah well, r=hwaara and please post patches as attachments in the future. ;)

Comment 10

[(not reading, please use [e-mail] instead)]

r/sr=sspitzer

as hwaara noted, post patches as attachments and not in the comments.

Comment 11

[(not reading, please use [e-mail] instead)]

yikes, this patch is bad!

what happend to this line:

<observes element="broadcaster_throbber" attribute="busy"/>

Comment 12

[(not reading, please use [e-mail] instead)]

see my patch in #85506.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

The patch works in my tree; that is to say when you click on it it loads a new
Nav window, or loads www.mozilla.org in the current open nav window, but maybe
we should use Seth's patch instead.  Also, about the pasting patches in bug
thing, sorry about that, I was just taking a shortcut like I've seen in bug
67398 (but I agree it's bad to do).

Comment 14

[(not reading, please use [e-mail] instead)]

stephend:

in your latest patch, you removed this line:

<observes element="broadcaster_throbber" attribute="busy"/>

why'd you remove it?

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: my fix from the duplicate

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

I believe I was copying other throbber styles from Editor, but I'll have to 
double check.

Comment 17

[(not reading, please use [e-mail] instead)]

taking from hewitt.  talked to stephend, and we'll go with my fix.

Comment 18

[Håkan Waara]

my r= still stands for seth's patch from the dup.

Comment 19

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 20

[(not reading, please use [e-mail] instead)]

fixed.

Comment 21

[fenella]

Win32 (2001-06-15-09 trunk)
This is fixed.