Build ID: 2001-05-30 FizzillaCFM Steps to reproduce: 1) Open a document in Editor. 2) Try to use commands in the submenus of the Format and Table menus. Actual results: The commands do nothing. Expected results: Expected the commands to work.
cc: twalker, do you see this?
sorry for spam, cc: shrir also.
Commmercial build 2001-06-01-04-trunk is fine. No problems using functionality in those menus. I checked linux and windows also, just to be sure. They are fine too.
Henri, please recheck...download latest build and try again...
cannot repro on any platform, marking wfm
verified in 6/1 build.
did anyone happen to notice the platform before you closed it WFM? did anyone try it on the reporter's platform?
Reopening based on pink's comments.
Now please test and verify on the reported platform.
I tried again (with the same build--it is the newest one available). The commands in submenus still don't work for me in FizzillaCFM on Mac OS X. However, they do work in the Classic build for me, too. So this is Mac OS X only.
can someone please verify on Mac OS X.
Confirming issue is only occuring with the carbon OS X Fizzila build. Tested with Fizzila 5/30 build under Mac OS X 10.0.3.
well Simon is Mr. Mac -- here ya go
Seems like a Carbon menu thing; cc beard.
i'll take this.
this turns out to be an OS bug in the Carbon menu manager. Calling ::DisableMenuItem() on a submenu from that menu's open event handler royally screws up the menu manager. I'm in contact with apple. Currently, the only workaround is to not disable any menu items in a submenu on osx. This would only affect composer, it seems.
hrm, ok, that isn't all of it. it still locks up, just now it takes a lot more to do it.
Mike, this is PDT+ bug. Tomorrow, on Tuesday, we'll try to build the first RTM candidate. It would be good, if this could be resolved ASAP.
i'm downgrading this. apple is looking into the menu manager problems and has already found one, but not for osx. I don't think it's necessarily our problem, and it seems to only be composer right now. we should reinvestiage after beta.
There are some mail submenu items that don't work (bug 91914)--related?
Apple has identified and fixed some bugs in the Carbon MenuManager on both 9 and X that mozilla uncovered. when we get newer seeds with the fixes, i'll revisit.
*** Bug 95663 has been marked as a duplicate of this bug. ***
Can someone please test and list exactly what submenu items don't work? There are some other "submenu commands not working" bugs that are not Mac specific and this is causing confusion (e.g., see bug 93653).
found this while skimming thru os x bugs...should check hierarchical menus in browser, just to be sure. nbaca, have you encountered this in mailnews windows? let me know if you need access to an os x box --my mac dualboots. unless of course, pink's 2001-06-15 18:54 comments still stand and this is editor-only... has anyone encountered this problem with hierarchical *context* menus? just curious.
erm, i meant pink's 2001-07-06 12:17 comments.
*** Bug 97160 has been marked as a duplicate of this bug. ***
Have we tested this with the latest seed from Apple?
yes, and it still doesn't work, though with carbonlib 1.4 it no longer takes out the machine. as a result, i can now debug it. that's what i'm working on in the next day or two.
*** Bug 97151 has been marked as a duplicate of this bug. ***
ok, we're in a world of hurt here. As of CarbonLib1.4, even regular submenus (ones that don't make changes in their onCreate handlers) only work once. It appears that the second time a submenu is accessed, ::MenuSelect() freaks and returns a menuID that's way out of bounds for either our menus or apple's internal ids. I'm talking to apple about this, and we're gonna need some help here.
This bug is a test stopper for intennational since we cannot test charsets in mail, editor... I'm afraid we are going to find more bugs when this one is fixed, and it may be too late... Can you raise priority in this bug? Anything we can do to help?
i am working with apple on this, but i'm going to be out for about a week and a half starting wednesday. unfortunately, dagley and sfraser are out the end of this week as well. One of them should probably own this issue until i get back online in virginia. my best guess is that there are bugs in the carbon Menu Manager that we are hitting. I'm not sure how we could change our code w/out turning off functionality.
the more i dig, the more i find wrong. we appear to be clearing out the menu and any of our internal menu stuctures as soon as the mouse is released on an item (when the menu goes away). This makes it impossible for us to later find the item in a submenu -- all the submenus and items in that submenu have been destroyed! I'm working on trying to cache the information from the event handlers (before menuSelect returns, by then it's too late), but there are OS bugs in the tracking handlers and no carbon event when an item has been selected. calgon, take me away!
after talking a bit to beard, it seems that the real thing to do is eschew all these peripheral issues and do the following: for every menu item, assign a unique 32-bit command id. make a map from this ID to the corresponding nsIMenuItem. install a carbon event handler to process this command event when the item is selected and then just go straight to the menuItem from there to execute the command. This gets rid of all the ugly code that scans over our menus and submenus looking for menu ids and items. I'll get on this as soon as i get back to va.
the reason why we're tearing down the Table menu prematurely is because of hyatt's bug that the oncreate event bubbles. since both the table menu and the submenu have oncreate events, the Table menus thinks it should be rebuilt every time the Insert submenu is opened. still playing...
i have it working 95%. i'll submit a patch tomorrow.
so do you remove ids from the map and create new ones each time we do a menu tear down/build cycle? Why is this an issue at all in the dynamic menu world, we should be getting equivalent behavior, no?
*** Bug 98279 has been marked as a duplicate of this bug. ***
saari, i have no idea what you just said ;)
Created attachment 48322 [details] [diff] [review] [patch] fixes our problems and works around os bugs
ok, looking for r/sr here. it looks pretty good on osx. there are other issues on os9, but those are apple bugs and we're not qualifying for os9. i tried the composer table insert menu (the main reason for this bug) and it works. I also tried the character encoding menus and they seem to work as well.
did a little bit of testing on os x [2001.09.04.08-comm]. olgam, could you let us know if there are other menu items that are affected? thx! * submenus from the main menu in the mailnews main window [eg, submenus from View, Message] and editor window don't work. * the Message submenu items [from main menu] don't seem to work for a mail standalone window. * submenus from the main menu in the browser seem fine. * submenus [for context menus] in editor, mailnews and mail standalone windows appear fine.
sairuh, all mail menus work just fine for me. i couldn't test standalone message window (networking no workie on my MP box), but i checked message compose. coudln't find a single proble. we might have to require the latest version of OSX (after 10.0.4) for certain bugs in the menu manager to be fixed, though it's strange that composer menus worked for you yet mail didn't
yeah, prolly best to revisit/retest once the official-post-10.0.4 upgrade is available. olgam, let me know if/when i could help you test this further.
*** Bug 98810 has been marked as a duplicate of this bug. ***
I have Mac OSX 10.0.4 and still see problems with the View menus which have submenus in mail. (Logged as bug 99507) Is this a dupe?
*** Bug 99507 has been marked as a duplicate of this bug. ***
Anyone know when the next release of Mac OSx is available? Will it make our next release? This makes many Mail menu submenus non-functional on branch for OSX :-(
Apple has publicly stated that Mac OS X 10.1 will ship in September. Considering bugs in 10.0.4, such as this one, we may well end up requiring Mac OS X 10.1 for the release version of Mozilla/Netscape 6.x for Mac OS X.
*** Bug 99544 has been marked as a duplicate of this bug. ***
i need r/sr on this patch please.
Comment on attachment 48322 [details] [diff] [review] [patch] fixes our problems and works around os bugs sr=sfraser
sairuh, i just tried my patch on 10.0.4 and all menus that you claim don't work work perfectly for me. I guess we're not going to have to require 10.1 after all. can anyone else verify this? Why are we getting such different results? opt fizzila build, tree from 9/17/01, 10.0.4
Comment on attachment 48322 [details] [diff] [review] [patch] fixes our problems and works around os bugs from r=saari in bug
PDT+. Pls get it in by 3 am.
*** Bug 99544 has been marked as a duplicate of this bug. ***
*** Bug 100358 has been marked as a duplicate of this bug. ***
landed on trunk and branch. if you have specific menu problems after the 9/19/01 bits, please file new bugs. this has serious zombie potential and i don't want to see this bug reopened.
I verified that Editor submenus work in build 2001091821. Thanks!
using 2001.09.19.04-branch on 10.0.4, tested thus far --and looks fine: * menus and submenus from the browser main menubar * menus and submenus from the editor main menubar yet to do: * context menus in browser * context menus in editor however, if anyone doesn't think verification of context menus is needed for *this particular bug* do let me know. i'll definitely get to 'em --but how much of a response i get here will affect how soon i'll get to 'em. (it'll get to the head of the queue if the response is ,"yes, it's relevant here!" :)
don't bother verifying context menus. they're not native, and thus would not suffer from any of these problems. any problems you find there would be totally different bugs.
pink: okidoke! vrfy'ing da branch. if someone beats me to the trunk, go ahead and mark this verified and remove the vtrunk kw...
checked the browser menus: vrfy fixed on the trunk [2001.10.03.20] on 10.0.4. sujay, could you vrfy this for the composer main menus/submenus on Mac OS 10.x? thx!
oh i did find one problem: crash opening an IM compose window. filed that as http://bugscape.mcom.com/show_bug.cgi?id=10102.
Confirming Table and Format sub-menus are functional in the Oct 5th OS X build.