836422 - Having methods named JS_NumberValue and JS::NumberValue might not be such a good idea

Status: NEW

(Core :: JavaScript Engine, task, P3)

Description

[Jeff Walden [:Waldo]]

The names are perhaps a little bit too similar.  The semantics are subtly different (JS_NumberValue canonicalizes NaNs to the js_NaN pattern).  We should rename so the differences are much more obvious, or we should remove the version that doesn't canonicalize and just have every place canonicalize.  I don't know if we can just always canonicalize, or if that'll be a perf it.  We'll have to try it and see if there are any hot spots to care about, or something.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Yeah, this is still peculiar.