The default bug view has changed. See this FAQ.

get import precedence right

VERIFIED FIXED in mozilla1.2alpha

Status

()

Core
XSLT
P3
normal
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: Axel Hecht, Assigned: sicking)

Tracking

Trunk
mozilla1.2alpha
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: TX_BRIDGE_1_1_FIXED)

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
import precedence rulez
xsl:template
xsl:strip-space, xsl:preserve-space
xsl:namespace-alias
xsl:attribute-set
xsl:variable, xsl:param (just top level vars, if I read that right)
xsl:output

xsl:decimal-format, xsl:key do not, if I got the spec right

We could have a list of txImportFrames (or so), to store this information.

Axel
(Reporter)

Updated

16 years ago
Depends on: 78068
(Reporter)

Updated

16 years ago
Priority: -- → P5
(Reporter)

Updated

16 years ago
Blocks: 92929
(Reporter)

Updated

16 years ago
Priority: P5 → P2
Target Milestone: --- → mozilla0.9.4
(Reporter)

Comment 1

16 years ago
setting milestone on the bugs that nisheeth wanted. Setting Priority up for
landing indication

Axel
pushing
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Created attachment 50836 [details] [diff] [review]
Precedence for attribsets, templates and whitespacefiltering. Ver 1
Comment on attachment 50836 [details] [diff] [review]
Precedence for attribsets, templates and whitespacefiltering. Ver 1

r=peterv, though I'm not confident I did a very thorough review. I want Pike to r it too.

Small nits:
-I prefer the { on a newline after a function definition
-No newline after a while () {
-Prefer mFoo for members and aFoo for parameters

The files you touched don't follow a particular style, so you could ignore those and leave them for the cleanup bug.
I got the following comments from Pike:

ProcessorState::addTemplate
- name should be const, too.
- match should be below the name check
- get a const string for mode, too.

ProcessorState::findTemplate
- how about changing the signature from String* aMode to const String& aMode?
- don't cut the lines
+                String priorityAttr = templ->
+                    mTemplate->getAttribute(PRIORITY_ATTR);
this way, 
+                String priorityAttr = 
+                    templ->mTemplate->getAttribute(PRIORITY_ATTR);
is better. The second instance, too. I don't like long lines, but this
is worse.

ProcessorState::getFoo:
+    while (frame = (ImportFrame*)frameIter.previous()) {
should be
+    while ((frame = (ImportFrame*)frameIter.previous())) {
IIRC

a macro for 
(ProcessorState::ImportFrame*)importFrame->current())
in XSLTProcessor?

fix the String() to NULL_STRING in XSLTProcessor

Status: NEW → ASSIGNED
Created attachment 51768 [details] [diff] [review]
patch that fixes petervs and Pikes comments
Comment on attachment 51768 [details] [diff] [review]
patch that fixes petervs and Pikes comments

got r=Pike over mail
Attachment #51768 - Flags: review+
Comment on attachment 51768 [details] [diff] [review]
patch that fixes petervs and Pikes comments

sr=jst
Attachment #51768 - Flags: superreview+
attachment 51768 [details] [diff] [review] is checked in. Keeping the bug open since there is more stuff 
that needs precedence
Target Milestone: mozilla0.9.5 → ---
Priority: P2 → P3
Target Milestone: --- → mozilla0.9.8
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Depends on: 117658
pushing
Target Milestone: mozilla0.9.9 → mozilla1.0
pushing :(
Target Milestone: mozilla1.0 → mozilla1.1alpha
...
Target Milestone: mozilla1.1alpha → mozilla1.1beta
Target Milestone: mozilla1.1beta → mozilla1.2alpha
fixed with the checkin of bug 117658
Whiteboard: TX_BRIDGE_1_1_FIXED
fixed with the branchlanding
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Reporter)

Comment 15

14 years ago
mass verifying
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.