836514 - Update reviewer list in the github wiki

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

There is a list of reviewers on https://github.com/mozilla/addon-sdk/wiki/contribute but I think it is out of date and that some people can be removed? or am I wrong?

Comment 1

[Will Bamberg [:wbamberg]]

I'd always thought that this is the correct list, and that it's actively maintained - at least, people are still regularly added to it, and it's the list I refer to when looking for a reviewer.

There are people on it who haven't been in the team for a long time. I'd always just assumed that the Jetpack review team was like the Hotel California, but maybe we should remove some people.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

cc'ing warner, atul, dietrich and drew. 

My feeling is that you guys are so far out of the loop that reviews from you would be potentially harmful. No offense. Is it okay if we remove you from our list?

Comment 3

[Dave Townsend [:mossop]]

Are there any people on there we don't trust to give a good review (that includes trusting them to pass it along if they know they can't review it)? I don't think so so I wouldn't have a problem leaving them all on. But there are a few there who have been out of the project for long enough that chances are they aren't going to be able to review anymore so we could remove those.

At the same time are we missing anyone?

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

I'm pretty sure that we have all of the current active reviews and previous reviewers listed.

Keeping the full list seems fine to me, but we should at least emphasize the active reviewers so that the reviews happen asap.

Comment 5

[Atul Varma [:atul]]

Hey, no offense taken--I agree that any review I give could be potentially harmful at this point.

It might be fun to have an honorary "reviewer emeritus" section for folks who used to be reviewers but have been out of the loop for a long time, just to provide that Hotel California vibe without endangering the project, but whatever is decided is fine with me!

Comment 6

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Atul Varma [:atul] from comment #5)

> It might be fun to have an honorary "reviewer emeritus" section for folks
> who used to be reviewers but have been out of the loop for a long time, just
> to provide that Hotel California vibe without endangering the project, but
> whatever is decided is fine with me!

I love it! +1. 

Atul - it's been so long, I feel like drinks are on me next time our paths cross. :D

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

done https://github.com/mozilla/addon-sdk/wiki/Contribute/e4fdad5fc8b10d089b40931b37647063ec675bec