Closed Bug 836524 Opened 7 years ago Closed 7 years ago

More compartment -> zone renaming

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(6 files)

Originally I hadn't planned on moving all this stuff to zones, but now I realize I must.
Attached patch part 1Splinter Review
Change up some assertions.
Attachment #708344 - Flags: review?(terrence)
Attached patch part 2Splinter Review
"Deadzones"!
Attachment #708345 - Flags: review?(jcoppeard)
Attached patch part 3Splinter Review
Gray marking.
Attachment #708346 - Flags: review?(jcoppeard)
Attached patch part 4Splinter Review
Preserving JIT code.
Attachment #708347 - Flags: review?(terrence)
Comment on attachment 708344 [details] [diff] [review]
part 1

Review of attachment 708344 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscompartment.cpp
@@ +289,5 @@
>  
>      if (vp->isString()) {
>          JSString *str = vp->toString();
>  
>          /* If the string is already in this compartment, we are done. */

s/compartment/zone/ in the comment.
Attachment #708344 - Flags: review?(terrence) → review+
Attachment #708347 - Flags: review?(terrence) → review+
Attached patch part 5Splinter Review
I guess this should have gone in with the previous patches. It's small though.
Attachment #708367 - Flags: review?(jcoppeard)
Attached patch part 6Splinter Review
Found some more of this junk.
Attachment #708392 - Flags: review?(jcoppeard)
Attachment #708345 - Flags: review?(jcoppeard) → review+
Attachment #708346 - Flags: review?(jcoppeard) → review+
Attachment #708367 - Flags: review?(jcoppeard) → review+
Attachment #708392 - Flags: review?(jcoppeard) → review+
You need to log in before you can comment on or make changes to this bug.