Closed Bug 836531 Opened 7 years ago Closed 7 years ago

Change getBuildConfiguration to output more information

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: gkw, Assigned: gkw)

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
Let us change getBuildConfiguration() in the js shell to output more information, i.e. if it is 32-bit or not, if it is 64-bit or not, and if it was compiled with ASAN support or not.

e.g. for a 64-bit build without ASAN support:

js> getBuildConfiguration()
({asan:false, debug:true, dtrace:false, e4x:true, 'exact-rooting':false, 'generational-gc':false, 'has-ctypes':false, 'has-gczeal':true, 'incremental-gc':true, methodjit:true, 'more-deterministic':true, 'oom-backtraces':false, profiling:false, 'rooting-analysis':false, threadsafe:false, 'trace-jscalls-api':false, valgrind:true, x64:true, x86:false})
js> getBuildConfiguration()['asan']
false
js> getBuildConfiguration()['x64']   
true
js> getBuildConfiguration()['x86'] 
false
js>
Attachment #708355 - Flags: review?(sphink)
Comment on attachment 708355 [details] [diff] [review]
patch v1

Review of attachment 708355 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #708355 - Flags: review?(sphink) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/774ba579fd39

in-testsuite- since this involves a shell-only function.
Assignee: general → gary
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/774ba579fd39
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.