836538 - Catch exceptions when we have no etag headers on packages

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

I removed the try {} catch{} thinking that getResponseHeader() will always return null (like on xhr) but alas.

Rob has a nice way to test that, using:
https://github.com/robhudson/packaged-app-server/blob/master/serve_packaged_apps.py

Just comment out L99 and L122 to disable the etags.

Comment 2

[Jason Smith [:jsmith]]

Comments for triage:

I'd track this, but wouldn't block. Technically the behavior right now is a fail fast method that prevents install without the etag due to the unchecked exception. Adding the try catch is a nice area of cleanup, but our v1 support primarily targets packaged app zip files being served with etags.

Comment 3

[[:fabrice] Fabrice Desré]

I disagree. We fail to install apps that should install, for no good reason. Zero risk, nice reward.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> I disagree. We fail to install apps that should install, for no good reason.
> Zero risk, nice reward.

Note - We didn't block on the other bug that talked about this exact situation with trying to install a packaged app without an etag. That actually was why I was pulling that not blocking piece out.

I'd definitely take an uplift here though.

Comment 5

[[:fabrice] Fabrice Desré]

This a regression from bug 829934 that was a blocker.

Comment 6

[Julien Wajsberg [:julienw]]

Technically this is not a regression because we were not installing apps without ETag before Bug 829934 anyway.

However I agree this must land. I don't care if this is through tef+ or approval.

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b42bd3d9cc23

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b42bd3d9cc23

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/fa9f1baae52b
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/afff6ff7d5cd

Comment 10

[Jason Smith [:jsmith]]

Verified through testing that I could install a packaged app which was served with no etags.