Simplify gray links in the GC

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 708362 [details] [diff] [review]
patch

I had to make some changes to this code for the zones work, and I realized that we can simplify it. I don't think we need to worry about debugger objects being in the list. We're supposed to be putting debugger objects in the same group and the objects they point to. Assuming we do this correctly, we'll never have to cross groups for debugger objects.

I'm thinking maybe it seemed like we needed this code because the grouping code didn't always correctly put the debugger stuff in the same group. Before that code was working, it probably looked like we might have debugger objects crossing into other groups.
Attachment #708362 - Flags: review?(jcoppeard)
Comment on attachment 708362 [details] [diff] [review]
patch

Review of attachment 708362 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that's much better!
Attachment #708362 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/3b53112a2a23
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.