Closed
Bug 836546
Opened 11 years ago
Closed 11 years ago
Simplify gray links in the GC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
10.34 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
I had to make some changes to this code for the zones work, and I realized that we can simplify it. I don't think we need to worry about debugger objects being in the list. We're supposed to be putting debugger objects in the same group and the objects they point to. Assuming we do this correctly, we'll never have to cross groups for debugger objects. I'm thinking maybe it seemed like we needed this code because the grouping code didn't always correctly put the debugger stuff in the same group. Before that code was working, it probably looked like we might have debugger objects crossing into other groups.
Attachment #708362 -
Flags: review?(jcoppeard)
Comment 1•11 years ago
|
||
Comment on attachment 708362 [details] [diff] [review] patch Review of attachment 708362 [details] [diff] [review]: ----------------------------------------------------------------- Nice, that's much better!
Attachment #708362 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b53112a2a23
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b53112a2a23
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•