Closed Bug 836609 Opened 11 years ago Closed 11 years ago

Data roaming warning dialog (requirement for Shira)

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:shira+, b2g18 fixed, b2g18-v1.0.1 fixed)

VERIFIED FIXED
blocking-b2g shira+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: arthurcc, Assigned: arthurcc)

References

Details

Attachments

(1 file)

A warning dialog should be displayed when users enable data roaming at the first time.

https://www.dropbox.com/s/w8vkbozizd3yswd/Roaming%20UI_Jan%2003.pdf
Kaze, this patch adds a data roaming warning dialog based on the latest UX spec. The logic of displaying the dialog is the same as the data connection warning dialog you've reviewed before. To better reuse the logic I've done a refactoring in this patch. Could you help review it? Thanks.

Stas, the following keys were added in the patch:
  notNow
  turnOn
  dataRoaming-warning-head
  dataRoaming-warning-message

The following keys were removed in this patch:
  dataRoaming-enabled
  dataConnection-warning-notNow
  dataConnection-warning-turnOn
Attachment #708468 - Flags: review?(stas)
Attachment #708468 - Flags: review?(kaze)
blocking-b2g: shira? → shira+
OS: Mac OS X → Gonk (Firefox OS)
QA Contact: wachen
Hardware: x86 → ARM
Want to make sure everyone knows that Shira is targeting 2/15 code freeze. 
Shira+ bugs needs more attention for unassigned, needinfo?,  review?
Full regression test is planned on 2/6. Need to have shira+ bugs landed by the end of 2/5 to be covered in full regression testing. Thanks
Stas, Kaze,
Please help with the reviewing of this patch please.
Flags: needinfo?(stas)
Flags: needinfo?(kaze)
Stas, Kaze,
Please help with the reviewing of this patch please.
Flags: needinfo?(stas)
Flags: needinfo?(kaze)
I have mainly two objections with this patch:
 • (nitpick) please use the common coding guidelines for if/else statements
 • why did you modify the two l10n entities? dataConnection-warning-notNow / dataConnection-warning-turnOn were fine, I don’t see why they should be renamed and put at the head of the *.properties file unless these strings are going to be used by several dialogs in this app (which isn’t likely).
Flags: needinfo?(kaze)
Comment on attachment 708468 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/7886

Sorry for the slow reaction time: first there was FOSDEM over the weekend, and then I wasn't sure how the branching will look like and how it impacted l10n.

Now that I know, r=me.  Thanks.
Attachment #708468 - Flags: review?(stas) → review+
Flags: needinfo?(stas)
Kaze, thanks for reviewing. Your comments were addressed except for the l10n part. Reasons I've commented in the pull request. We can have a discussion on it.
Comment on attachment 708468 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/7886

Makes sense. r=me, please address the last nitpick before merging.
Thanks Arthur!
Attachment #708468 - Flags: review?(kaze) → review+
Stas, Kaze, thanks for helping.
Arthur, good job!

Verified that changes is in 2013-02-06 pvt b2g18 user build.
Status: RESOLVED → VERIFIED
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: