836687 - [Settings] The string doesn't translate after changing language

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : The string doesn't translate after changing language
2. Precondition : 
3. Tester's Action : Setting - Phone lock - Passcode lock turn on - change any language
4. Detailed Symptom (ENG.) : The 'immediately' string doesn't change.
5. Expected : 
6. Reproducibility: Y
1)Frequency Rate : 100%
7. Gaia revision : f46757775e07d314913b4a5ae975fa131d1c7c4b

Comment 1

[Leo]

Attachment: Screenshot

Comment 2

[Leo]

Pleze check to translate all string of select popup.
Any string of select popup doesn't translate well.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this a regression?  QA can you confirm and also see if this happens with v1.1 shipping locales?

Comment 4

[Dietrich Ayala (:dietrich)]

Specific case is blocking because of potential to lock yourself out of the phone. Otherwise, a string issue like this on a Settings subscreen would not normally hold a release back.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8849

Evelyn, please help the change. Feel free to merge it directly once you grant the review (hopefully :D).

Comment 6

[[e-mail] [:onecyrenus]]

(In reply to [e-mail] from comment #3)
> Is this a regression?  QA can you confirm and also see if this happens with
> v1.1 shipping locales?

Just confirmed that this happens with v1.1

Comment 7

[Evelyn Hung]

Comment on attachment 730120 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8849

r=me, look good. Thank you so much.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/aac03bb8501f8a59536aa7da752074142552705d

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit aac03bb8501f8a59536aa7da752074142552705d as:
v1-train: a04db43fb8aaf92039aab9797123dceae5d9fd77

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominated for tef? since it is the same as a tef+ bug (bug 859436).

Comment 11

[Jeni]

Phone lock is now fully localized. 
Verified fix on 

Unagi Build ID: 20130409070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/cfef36c0c8bc
Gaia: a80be95f553de517e5d8a159e04511cda5e38be4

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.0.1:https://github.com/mozilla-b2g/gaia/commit/aff876b051c51d091cecf322b90c4f0093281b5e

Stas, I found some strings existed in settings.en-US.properties are not listed in other language files, for example, "availableSize". Could you help check it?

Comment 13

[Daniel Coloma:dcoloma]

marking v1.0.1 as fixed basd comment 12

Comment 14

[Staś Małolepszy :stas]

(In reply to Arthur Chen [:arthurcc] from comment #12)
> Stas, I found some strings existed in settings.en-US.properties are not
> listed in other language files, for example, "availableSize". Could you help
> check it?

Arthur, how is this related to this bug?  Can you point to a specific language file that you checked?

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

I checked settings.zh-TW.properties. However, I was told that there is another repository for language files, so what I mentioned might not a real issue.

Comment 16

[Staś Małolepszy :stas]

(In reply to Arthur Chen [:arthurcc] from comment #15)
> I checked settings.zh-TW.properties. However, I was told that there is
> another repository for language files, so what I mentioned might not a real
> issue.

Correct.  Just FYI:

v1-train locales: https://hg.mozilla.org/gaia-l10n/
v1.0.1 locales: https://hg.mozilla.org/releases/gaia-l10n/v1_0_1