836722 - [GALLERY] The option "wallpaper" shows the text "null" if the device is configured in spanish

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[rafael.marquez]

Gecko-066b9d7
Gaia-f7f5a0c

*Procedure
1. Open setting and set spanish languaje
2. Open gallery app
3. Select a picture and press share button

*Expected
The user have a option to  set the photo as wallpaper for the device

*Actual Result
The option "wallpaper" shows the text "null" if the device is configured in spanish

Comment 1

[Alex Keybl [:akeybl]]

This feels like a blocker, since it's a common user scenario in our default language for v1.0.0.

Comment 2

[David Flanagan [:djf]]

This is an l10n bug. The string "null" is coming from this file: https://hg.mozilla.org/gaia-l10n/es/file/b23ae1279338/apps/wallpaper/manifest.properties

Cc'ing Guillermo Lopez who is the author of that file.  

Also cc'ing Kaze, Stas and Axel since they do l10n and probably know how to get this fixed.

I'd love it if someone would take this bug from me. I can't do the localization myself, and even if someone told me the right strings, I don't know the procedure for getting the changes checked in to the gaia-l10n repo.

Comment 3

[David Flanagan [:djf]]

Setting the late-l10n flag and using needinfo to get this on Stas' radar.

Stas: would you reassign this bug to someone who is able to fix it?

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Taking,

this was a problem when I was using stas' scripts instead of official en-US repository. I changed to the repo, but I forgot to edit some of those files.

Comment 5

[Guillermo López :willyaranda (probably SLOW response)]

Pushed, among other things.

https://hg.mozilla.org/gaia-l10n/es/rev/d8637fafdbe9

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

What is the status of this for B2G v1.0.0 and v1.0.1?

If it's fixed for v1.0.0, we should set status-b2g18-v1.0.0 to 'fixed'.
If it's fixed for v1-train, we should set status-b2g18 to 'fixed'.

Comment 7

[Axel Hecht [:Pike]]

We're only have a single l10n repo at this point, so I'm setting flags like crazy.

Comment 8

[pallavi]

Unagi,Build ID 20130214070203
Kernel Dec 5
Gecko:http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e
Gaia: 6544fdb8dddc56f1aefe94482402488c89eeec49

This issue has been fixed