836831 - Play controls in the Gallery/Camera apps are inconsistent with those in the Music and Video apps

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue

unagi, seen while running

Gecko: 2175ec7a644f606bec3b7e85ac660de456aae518
Gaia: 7a393bb762f8586fa0357378f966184d6ac8562c

STR:
1. Record a video using the camera app
2. View the video you just recording from the gallery app
3. Observe the attached screenshot

Note that if you play the same video in the video app, the control looks normal - the size is smaller and there are no parentheses.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I don't know if this was intentional... I am guessing it was... I do have to agree with Marcia... it does seem odd...

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

might be a dup of bug 833750?

Comment 3

[itsprameet]

I am interested in working on this bug.

Comment 4

[amitav.anand]

Attachment: PR

Removed the bold circle around pause button.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-07-15-09-53-22.png

Testing out the patch, there are no parenthesis any more.  Which fixes the bug.  

The thing I did notice is that the area around the pause has a slightly different color than the rest of the bar.  Screenshot doesn't seem to do it justice in terms of the difference.  On device it's more noticible after tilting the device at an angle.

I'd still take this patch.  Thanks for the fix!

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Need review from the dev though.  I did a QA review.

Comment 7

[Chris Lord [:cwiiis]]

This is still an issue. Eric, what's the right way to go about this - change video app to match gallery/camera or change gallery to match video?

Comment 8

[Eric Pang [:epang] UX]

(In reply to Chris Lord [:cwiiis] from comment #7)
> This is still an issue. Eric, what's the right way to go about this - change
> video app to match gallery/camera or change gallery to match video?

Hey Chris, thanks for flagging me on this!  I'll hand off to Amy Lee though since she's the owner of media apps and understands camera and gallery best.  Amy can you take a look? thx!

Comment 10

[Amy Lee [:amylee] UX]

(In reply to Eric Pang [:epang] from comment #8)
> (In reply to Chris Lord [:cwiiis] from comment #7)
> > This is still an issue. Eric, what's the right way to go about this - change
> > video app to match gallery/camera or change gallery to match video?
> 
> Hey Chris, thanks for flagging me on this!  I'll hand off to Amy Lee though
> since she's the owner of media apps and understands camera and gallery best.
> Amy can you take a look? thx!

Hi Chris, 

The gallery/camera app should match the video app controls. I would also check in with Wilson Page to see if he's working on any sort of common control component for media playback controls.

Thanks!

Comment 11

[Chris Lord [:cwiiis]]

Over to you, Wilson :) Any work happening here, or is someone free to tackle this?

Comment 12

[Wilson Page [:wilsonpage]]

I think it would make sense for us to make a single <gaia-media-controls> component to be dropped into Gallery, Music and Camera. Amy, do you have a design we could use that would work for all three use-cases?

Comment 13

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #12)
> I think it would make sense for us to make a single <gaia-media-controls>
> component to be dropped into Gallery, Music and Camera. Amy, do you have a
> design we could use that would work for all three use-cases?

Hi Wilson, 

Please use the current playback control in the video app as a component and drop it into gallery, music, and camera. Thanks!

Comment 14

[Wilson Page [:wilsonpage]]

Amy, just thought, should the video/gallery/camera have the skip forward/back buttons? I'm don't really understand their use-case.

Comment 15

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #14)
> Amy, just thought, should the video/gallery/camera have the skip
> forward/back buttons? I'm don't really understand their use-case.

Hi Wilson, 

I think the video/gallery/camera should have rewind/forward icons (double arrows) instead of the skip icon. In those cases I would say the you should be able to jump ahead/back in increments during a video. Gonna NI Tiff to confirm interaction.

Comment 16

[Tiffanie Shakespeare [:tif]]

hey guys - check out this bug I created for the same issue...
https://bugzilla.mozilla.org/show_bug.cgi?id=1011795

Comment 17

[BMO Automation]

Firefox OS is not being worked on