836850 - Make it possible to implement several WebIDL interfaces using the same native class

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Currently this seems to be impossible due to the PrototypeIdMap, and it looks like that's Ben's fault.  ;-)

You can see the resulting ugliness in my upcoming patch to bug 836599.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So turns out we had code that tried to make this work... it was just buggy.  Patch coming up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch and use of the new ability for sharedlist

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 711379 [details] [diff] [review]
Patch and use of the new ability for sharedlist

Review of attachment 711379 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Configuration.py
@@ +60,3 @@
>              otherDescriptors = [d for d in self.descriptors
> +                                if d.nativeType == nativeType]
> +            descriptor.unsharedImplementation = len(otherDescriptors) == 1

Maybe:

any(d.nativeType == descriptor.nativeType and d != descriptor for d in self.descriptors)?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Maybe:

I'd need a negation of that, so I wrote it like so:

            descriptor.unsharedImplementation = all(
                d.nativeType != descriptor.nativeType or d == descriptor
                for d in self.descriptors)

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d32064860f36

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d32064860f36