836877 - mach should fail if running on Python 3

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Alex Xu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130126165632

Steps to reproduce:

hg clone .../mozilla-central
cd mozilla-central
./mach build

Using Python 3.2.3 on Gentoo.


Actual results:

Traceback (most recent call last):
  File "mach", line 53, in <module>
    import mach.main
ImportError: No module named mach.main

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "mach", line 57, in <module>
    import mach.main
  File "/home/alex/mozilla/python/mach/mach/main.py", line 29, in <module>
    from .logging import LoggingManager
  File "/home/alex/mozilla/python/mach/mach/logging.py", line 12, in <module>
    import blessings
  File "/home/alex/mozilla/python/blessings/blessings/__init__.py", line 275
    u''.join(self._resolve_formatter(s) for s in formatters))
      ^
SyntaxError: invalid syntax

Comment 1

[Gregory Szorc [:gps]]

We don't support building on Python 3. We should catch this.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Reject Python 3, v1

Comment 3

[Jeff Hammel]

f+, though I'd make the error message more like: "Mach requires python 2.7.x to run"..., perhaps refering o the bug for getting our **** on python 3

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/95bec0e5a600