836878 - Metro dialogs are squished up to the top of the screen

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Theme, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

When we display any dialog or prompt (for example, press the "Clear private data" button in the options flyout, or type javascript:alert(1) in the location bar), it takes up the full screen.  This is because the main <stack> no longer grows to fill the window.  This patch fixes this by restoring the "flex" attribute on the <stack> which was part of the original XUL Fennec code:

http://hg.mozilla.org/mozilla-central/file/cbeab7da0e3a/mobile/xul/chrome/content/browser.xul#l167

Previously, Metro relied on the stack growing to fit its children, but this caused problems like bug 816552.  (This bug is probably a regression from the patch in bug 816552.)   I think going back to flex="1" is more robust than depending on the child element sizes.  I think this may fix some other subtle layout bugs, and make it easier to remove a buch of code in ContentAreaObserver.

Comment 1

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/projects/elm/rev/869291a72efd