Closed Bug 836953 Opened 10 years ago Closed 10 years ago

BaselineCompiler: Don't emit multiple ICSetElem_Dense stubs with the same shape+type

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We often generate multiple SetElem_Dense stubs for the same shape+type combinations when we fall back because of a bounds check or hole check failure.

Check the chain so that we don't generate more than one of these stubs.
Attached patch Patch.Splinter Review
Attachment #708832 - Flags: review?(jdemooij)
Attachment #708832 - Flags: review?(jdemooij) → review+
Can this be marked FIXED?
Yeah.  Just waiting on TBPL before closing.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.