Closed Bug 836954 Opened 9 years ago Closed 9 years ago

Mark frame GetBaseline() impls as MOZ_OVERRIDE

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

GetBaseline() declarations:
https://mxr.mozilla.org/mozilla-central/search?string=nscoord+GetBaseline%28&find=.h%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

All of those (except for the nsIFrame one) can & should be declared as MOZ_OVERRIDE.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #708875 - Flags: review?(dbaron)
(The patch marks our one impl of GetCaretBaseline() in nsBlockFrame as MOZ_OVERRIDE, too.)
Comment on attachment 708875 [details] [diff] [review]
fix

r=dbaron
Attachment #708875 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/1052782fd20d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.