Closed
Bug 836954
Opened 11 years ago
Closed 11 years ago
Mark frame GetBaseline() impls as MOZ_OVERRIDE
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
9.05 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
GetBaseline() declarations: https://mxr.mozilla.org/mozilla-central/search?string=nscoord+GetBaseline%28&find=.h%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central All of those (except for the nsIFrame one) can & should be declared as MOZ_OVERRIDE.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
(The patch marks our one impl of GetCaretBaseline() in nsBlockFrame as MOZ_OVERRIDE, too.)
Comment on attachment 708875 [details] [diff] [review] fix r=dbaron
Attachment #708875 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1052782fd20d
Flags: in-testsuite-
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1052782fd20d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•